clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity
4,956 commits 2 branches 0 tags 67 MiB
Commit graph

15 commits

Author SHA1 Message Date
ragnarok-clanker
b3f2ac575e Confirm 2 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/Skills/SkillInfo.h 
Batch #11743 by StrawberrysherbetIX: 1 byte-identical, 1 confirmed by peer review.

- fn_08322 IsSupportSkill: byte-identical (already on main)
- fn_11732 CSkillInfo::MatchesShortcut: logic confirmed by peer review (already on main)

Peer-reviewed-by: Yommy, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-05 04:36:16 +00:00
ragnarok-clanker
dbd7a40e2f Confirm fn_12543 (CSkillInfo::operator=) 
Batch #11761 by Yommy: 1 byte-identical, 0 confirmed by peer review.

- fn_12543 CSkillInfo::operator=: byte-identical (already on main)

Merged automatically: every function is byte-identical to the original.
 2026-11-05 03:35:15 +00:00
ragnarok-clanker
e0d25b6324 Decompile fn_03339 (CSkillActionMgr::GetInstance) 
Batch #9851 by ntrl: 0 byte-identical, 1 confirmed by peer review.

- fn_03339 CSkillActionMgr::GetInstance: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-02 02:50:16 +00:00
ragnarok-clanker
89336cf88f Decompile fn_03339 (CSkillActionMgr::GetInstance) 
Batch #3776 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_03339 CSkillActionMgr::GetInstance: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-29 23:38:45 +00:00
ragnarok-clanker
efde6c3c94 Decompile 5 functions in Source/Contents/Skills/SkillActionSpiritHandler.cpp, Source/Contents/Skills/SkillActionTroubadour.cpp, ... 
Batch #3224 by youko: 5 byte-identical, 0 confirmed by peer review.

- fn_08954 CSkillAction_SH_HYUN_ROKS_BREEZE::Slot03: byte-identical
- fn_08956 CSkillAction_SH_HYUN_ROKS_BREEZE::Slot14: byte-identical
- fn_08965 CSkillAction_SH_BLESSING_OF_MYSTICAL_CREATURES::Slot00: byte-identical
- fn_08968 CSkillAction_SH_CHUL_HO_BATTERING::Slot02: byte-identical
- fn_09014 CSkillAction_TR_RHYTHMSHOOTING::Slot02: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/Skills/SkillActionSpiritHandler.cpp, Source/Contents/Skills/SkillActionTroubadour.cpp, Source/Contents/Skills/SkillActionWindHawk.cpp
 2026-10-29 21:01:18 +00:00
ragnarok-clanker
898712958b Decompile 3 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/Skills/SkillInfo.h 
Batch #3108 by eAthena: 3 byte-identical, 0 confirmed by peer review.

- fn_08441 CSkillAction_BO_EXPLOSIVE_POWDER::Slot05: byte-identical
- fn_08475 CSkillAction_DK_MADNESS_CRUSHER::Slot04: byte-identical
- fn_08495 CSkillAction_DK_HACKANDSLASHER_ATK::Slot02: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-29 20:31:24 +00:00
ragnarok-clanker
050e51d0e5 Decompile 11 functions in Source/Contents/Skills/SkillActionKarnos.cpp, Source/Contents/Skills/SkillInfo.h 
Batch #3104 by youko: 11 byte-identical, 0 confirmed by peer review.

- fn_03340 CSkillAction_KR_DOUBLE_SLASH::Slot02: byte-identical
- fn_03342 CSkillAction_KR_NASTY_SLASH::Slot02: byte-identical
- fn_03344 CSkillAction_KR_CLAW_WAVE::Slot01: byte-identical
- fn_03345 CSkillAction_KR_CLAW_WAVE::Slot02: byte-identical
- fn_03348 CSkillAction_KR_EARTH_DRILL::Slot02: byte-identical
- fn_03350 CSkillAction_KR_EARTH_STAMP::Slot02: byte-identical
- fn_03352 CSkillAction_KR_GROUND_BLOOM::Slot02: byte-identical
- fn_03357 CSkillAction_KR_THUNDERING_FOCUS::Slot02: byte-identical
- fn_03359 CSkillAction_KR_THUNDERING_FOCUS_S::Slot02: byte-identical
- fn_03364 CSkillAction_KR_ICE_PILLAR::Slot14: byte-identical
- fn_03365 CSkillAction_KR_ICE_PILLAR::Slot02: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-29 20:27:31 +00:00
ragnarok-clanker
8e2404c0da Decompile 18 functions in Source/Contents/Skills/SkillActionAlitea.cpp, Source/Contents/Skills/SkillInfo.h 
Batch #3095 by youko: 18 byte-identical, 0 confirmed by peer review.

- fn_03190 CSkillAction_AT_PULSE_OF_MADNESS::Slot02: byte-identical
- fn_03195 CSkillAction_AT_FRENZY_FANG::Slot02: byte-identical
- fn_03197 CSkillAction_AT_PINION_SHOT::Slot01: byte-identical
- fn_03198 CSkillAction_AT_PINION_SHOT::Slot02: byte-identical
- fn_03202 CSkillAction_AT_QUILL_SPEAR::Slot01: byte-identical
- fn_03203 CSkillAction_AT_QUILL_SPEAR::Slot02: byte-identical
- fn_03207 CSkillAction_AT_NATURE_HARMONY::Slot01: byte-identical
- fn_03208 CSkillAction_AT_NATURE_HARMONY::Slot02: byte-identical
- fn_03213 CSkillAction_AT_GRAVITY_HOLE::Slot01: byte-identical
- fn_03214 CSkillAction_AT_GRAVITY_HOLE::Slot02: byte-identical
- fn_03218 CSkillAction_AT_CHILLING_BLAST::Slot02: byte-identical
- fn_03220 CSkillAction_AT_GLACIER_MONOLITH::Slot14: byte-identical
- fn_03221 CSkillAction_AT_GLACIER_MONOLITH::Slot02: byte-identical
- fn_03224 CSkillAction_AT_GLACIER_NOVA::Slot02: byte-identical
- fn_03228 CSkillAction_AT_GLACIER_STOMP::Slot02: byte-identical
- fn_03230 CSkillAction_AT_ROARING_CHARGE::Slot02: byte-identical
- fn_03232 CSkillAction_AT_ROARING_CHARGE_S::Slot02: byte-identical
- fn_03236 CSkillAction_AT_FURIOS_STORM::Slot02: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/Skills/SkillActionAlitea.cpp
 2026-10-29 20:24:35 +00:00
ragnarok-clanker
d7862ef5c4 Decompile 9 functions in Source/Utility/Math/Vector3d.h, Source/Utility/Math/AffineMatrix.h, ... 
Batch #1843 by ragnarok-clanker: 1 byte-identical, 8 confirmed by peer review.

- fn_02024 ClientRadians: logic confirmed by peer review
- fn_17668 WorldScene::GetGameActorByAID: logic confirmed by peer review
- fn_21057 CRenderObject::GetTargetPos: logic confirmed by peer review
- fn_17667 WorldScene::GetGameActorByAidIncludeMe: logic confirmed by peer review
- fn_21290 CGameMode::NotifyItemBounds: logic confirmed by peer review
- fn_03089 CEffect::Slot25: logic confirmed by peer review
- fn_08405 CellWorldPosition: logic confirmed by peer review
- fn_19762 EffectPrimitiveSlot::EffectPrimitiveSlot: byte-identical (already on main)
- fn_19865 DrawEffectPrimitive15: logic confirmed by peer review

Peer-reviewed-by: Yommy, eAthena, ragnarok-clanker
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 22:49:51 +00:00
ragnarok-clanker
be749d87c8 Decompile 3 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/Skills/SkillInfo.h 
Batch #1771 by Yommy: 3 byte-identical, 0 confirmed by peer review.

- fn_08371 CSkillAction_ABC_CHASING_BREAK::Slot07: byte-identical
- fn_08375 CSkillAction_ABC_CHASING_SHOT::Slot07: byte-identical
- fn_08385 CSkillAction_ABC_ABYSS_FLAME_ATK::Slot03: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 22:12:16 +00:00
ragnarok-clanker
eba26963c9 Add SkillId enum and name SkillInfo skill helpers 
SkillId.h: the full SKID table (1929 entries) from skillinfoz/skillid.lua. SkillInfo.cpp: every numeric skill ID replaced by its SkillId name; Sub773A00/Sub773CB0/Sub773CD0/Sub7745B0/CSkillActionMgr::Sub77B4A0 renamed IsOptionalSelfTargetSkill/HidesUseFailureMessage/IsSupportSkill/ShowsCastEffect/CSkillActionMgr::IsSupportAction from their call sites; CSkillInfo::operator= copies scalars by assignment instead of memcpy. Compiled code unchanged (all includers checked).
 2026-10-28 22:19:15 +01:00
ragnarok-clanker
21ea249664 Decompile 2 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/Skills/SkillInfo.h 
Batch #1707 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_08322 Sub773CD0: logic confirmed by peer review
- fn_08413 CSkillActionMgr::Sub77B4A0: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 20:39:14 +00:00
ragnarok-clanker
d766d07a84 Decompile fn_08319 (Sub7739F0) 
Batch #1224 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_08319 Sub7739F0: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-27 21:41:40 +00:00
ragnarok-clanker
9ac3d05245 Maintenance: Add mandatory field offset markers /* XXXX */ and assertions to Contents headers (part 2: Items, Models, Movies, Skills, 
Batch #1063 by ragnarok-clanker: no function's compiled code changes; checked with 62 compiled unit(s), including every includer of Source/Contents/Items/ItemNaming.h, Source/Contents/Models/ModelActor.h, Source/Contents/Models/ModelRendering.h, Source/Contents/Models/ModelSpatial.h, Source/Contents/Movies/BinkMovie.h, Source/Contents/Movies/BinkMovies.h, Source/Contents/PlayerNameDictionary.h, Source/Contents/Skills/AutomaticSkills.h, Source/Contents/Skills/ClientSkills.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Skills/SkillInfo.h, Source/Contents/Sound/SoundMgr.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/World/WorldModelLoading.h, Source/Contents/World/WorldModelView.h, Source/Contents/World/WorldRayQuery.h.
 2026-10-27 13:52:05 +00:00
ragnarok-clanker
a47d20f8be Reconstruct readable C++ and organize cohesive source subsystems 
Administrative source import: native x86 compilation passed for 423 authored units. Source placement and submission states are migrated separately; this commit does not imply peer acceptance.

Previous head: 35d2a8cb36
Payload SHA256: 592f016d2730c5593bb653aa054c1e5f76a6df72c8f5a09e66f74876e2e33dee
 2026-10-25 07:42:41 +00:00
Renamed from Source/Contents/SkillInfo.h (Browse further)