clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity
6,625 commits 2 branches 0 tags 77 MiB
Commit graph

51 commits

Author SHA1 Message Date
ragnarok-clanker
dc3d5ce1a5 Maintenance: Resubmission of 14942 (gate: three existing in-class helpers whose lines changed lacked an annotation; marked // INLINED 
Batch #14943 by ragnarok-clanker: no function's compiled code changes; checked with 741 compiled unit(s), including every includer of Source/ActorPickNode.h, Source/Client/Browser/BrowserClientSite.h, Source/Client/Browser/BrowserPopupDispatch.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Mode/CMode.h, Source/Client/Mode/ModeDragState.h, Source/Client/Replay.h, Source/Client/Session.h, Source/Client/Stove/StoveMgr.h, Source/Contents/AchievementMgr.h, Source/Contents/ActorNameCard.h, Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/GroundScope.h, Source/Contents/Actors/Item.h, Source/Contents/Actors/Npc.h, Source/Contents/Actors/Pc.h, Source/Contents/Actors/RenderObjectState.h, Source/Contents/Actors/Skill.h, Source/Contents/AdventureGuideMgr.h, Source/Contents/Camera/Camera.h, Source/Contents/Camera/CameraState.h, Source/Contents/CashEmotionMgr.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/EffectResourceSwitcher.h, Source/Contents/Effects/AMachineEffect.h, Source/Contents/Effects/AcidifiedThrow.h, Source/Contents/Effects/AxeBoomerang.h, Source/Contents/Effects/BlastForge.h, Source/Contents/Effects/CaneOfEvilEyeEffect.h, Source/Contents/Effects/CharacterParticleBundle.h, Source/Contents/Effects/CloudKillEffect.h, Source/Contents/Effects/Effect.h, Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectEmitter.h, Source/Contents/Effects/EffectMaker.h, Source/Contents/Effects/EffectPrimitiveState.h, Source/Contents/Effects/FuumaShouakuEffect.h, Source/Contents/Effects/GravityControlEffect.h, Source/Contents/Effects/HealSpEffect.h, Source/Contents/Effects/Level99Effect.h, Source/Contents/Effects/MapChainEffect.h, Source/Contents/Effects/MonsterSkillEffects.h, Source/Contents/Effects/MsgEffect.h, Source/Contents/Effects/NyanggrassEffect.h, Source/Contents/Effects/Particle.h, Source/Contents/Effects/PowderingEffect.h, Source/Contents/Effects/RagEffectState.h, Source/Contents/Effects/RectUpEffect.h, Source/Contents/Effects/ShadowExceedEffect.h, Source/Contents/Effects/SkillEffects.h, Source/Contents/Effects/SpriteParticle.h, Source/Contents/Effects/StormCannonEffect.h, Source/Contents/Effects/ThrowEffects.h, Source/Contents/EntryQueueMgr.h, Source/Contents/EquipmentResourceMgr.h, Source/Contents/FlyingShipRouteInfo.h, Source/Contents/Ground/GroundGeometry.h, Source/Contents/GuildInfo.h, Source/Contents/Items/ItemDescription.h, Source/Contents/Items/ItemInfo.h, Source/Contents/MapSkyMgr.h, Source/Contents/Messenger/MessengerWindows.h, Source/Contents/Models/ModelNode.h, Source/Contents/NavigationManager.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/RDamageVar.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/RodexMailStore.h, Source/Contents/RouletteMgr.h, Source/Contents/Schedule/Schedule.h, Source/Contents/SignBoard/SignBoard.h, Source/Contents/Skills/ClientSkills.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Skills/SkillInfo.h, Source/Contents/SpriteLayerDrawing.h, Source/Contents/TipBoxTitles.h, Source/Contents/UserData/AccountLinkedUserDataMgr.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/World/World.h, Source/Contents/WorldView/WorldViewData.h, Source/Render/Primitives/LightmappedPrimitive.h, Source/Render/Primitives/RenderPrimitive.h, Source/Render/Renderer.h, Source/Render/Textures/SpritePixels.h, Source/Render/Textures/Texture.h, Source/Resource/EZeffectResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Sprites/ActionResource.h, Source/Resource/World/GroundResource.h, Source/Resource/World/WorldResource.h, Source/Resource/XmlNode.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UISlotBmpButton.h, Source/UI/Buttons/UISpriteButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITextureButton.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/CashEmotion/UICashEmotionPack.h, Source/UI/CashShop/UICashShopWnd.h, Source/UI/Chat/UIChatRoomMakeWnd.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Chat/UISubChatMiniWnd.h, Source/UI/Chat/UIWhisperWnd.h, Source/UI/Clan/UIClanWnd.h, Source/UI/Dialogs/UIBookWnd.h, Source/UI/Dialogs/UIChooseWarpWnd.h, Source/UI/Dialogs/UIMenuWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIMinimapZoomWnd.h, Source/UI/Dialogs/UINpcEditDialogWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UISayDialogWnd.h, Source/UI/Dialogs/UISelectCartWnd.h, Source/UI/Dialogs/UITipboxWnd.h, Source/UI/Edit/UIEditBoxEx.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIEditCtrl_Currency.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/Enchant/EnchantUI.h, Source/UI/Exchange/UIExchangeUI.h, Source/UI/FrameSkin.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Gauges/UIPcGage.h, Source/UI/Guild/UIGuildHelperWnd.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Guild/UIGuild_Storage_Log.h, Source/UI/Item/UIEquipmentPropertiesWnd.h, Source/UI/Item/UIItemBaseWnd.h, Source/UI/Item/UIItemPurchaseWnd.h, Source/UI/Item/UIItemSellWnd2.h, Source/UI/Item/UIItemShopWnd.h, Source/UI/Item/UIItemShopWnd2.h, Source/UI/Item/UIItemStoreFindWnd.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Item/UIItemWnd.h, Source/UI/Item/UIMerchantItemLogWnd.h, Source/UI/Item/UIParaItemShopWnd.h, Source/UI/Items/UICardItemIllustWnd.h, Source/UI/Items/UIEquipWnd.h, Source/UI/Items/UIExchangeWnd.h, Source/UI/Items/UIGameItem.h, Source/UI/Items/UIItemCollectionWnd.h, Source/UI/Items/UIItemIdentifyWnd.h, Source/UI/Items/UIItemParamChangeDisplayWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Layout/WindowGeometry.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UIComboBoxV2Wnd.h, Source/UI/Lists/UIImgMenu.h, Source/UI/Lists/UIListBoxID.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Lists/UIMemberListBox.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITagListBox.h, Source/UI/Lists/UITreeView.h, Source/UI/Menu/UIMenuIconWnd.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/ProbabilityTable/UIProbabilityTable.h, Source/UI/Quest/UIQuestDisplay.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Rodex/UIRodexInboxWnd.h, Source/UI/RuneSystem/UIRuneSystemWindows.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemMyShopWnd.h, Source/UI/Shop/UIMerchantItemPurchaseMSGWnd.h, Source/UI/Shop/UIMerchantItemPurchaseWnd.h, Source/UI/Shop/UIMerchantItemShopWnd.h, Source/UI/Shop/UIMerchantMirrorItemWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/Skill/UISkillDescribeWnd.h, Source/UI/Skill/UISkillListWnd.h, Source/UI/SkillDelayInfo/SkillDelayInfo.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/CreateLineInfo.h, Source/UI/Text/UIAchWnd.h, Source/UI/Text/UIBalloonText.h, Source/UI/Text/UINameBalloonText.h, Source/UI/Text/UIStaticTextControl.h, Source/UI/Text/UIString.h, Source/UI/Text/UITextViewerControl.h, Source/UI/UIBarGraph.h, Source/UI/UIBartermarketWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UILapineScrollBar.h, Source/UI/UIMacroBlackListCheckWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIMacroReport.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/UIPreviewEquipWnd.h, Source/UI/UIRefiningWnd.h, Source/UI/UIScrollWnd.h, Source/UI/UISlotBitmap.h, Source/UI/Window/FuncDrawWNDChar.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UIChatRoomWnd.h, Source/UI/Window/UICollectionSystemWnd.h, Source/UI/Window/UIControl.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginOTPWnd.h, Source/UI/Window/UILoginWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UIMonsterInfoWnd.h, Source/UI/Window/UINavigationHelpWnd.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIRoMapWnd.h, Source/UI/Window/UIRodexContentsWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UITransMenuWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWindowMgr.inl, Source/Utility/Lexicon/LexiconSerializer.h.
 2026-11-08 16:44:36 +00:00
ragnarok-clanker
521b52384c Maintenance: Replace LookupMessage(<integer>) with the existing MSGSTRINGID constant of the same value (3596 sites, 162 files; each v 
Batch #14938 by ragnarok-clanker: no function's compiled code changes; checked with 162 compiled unit(s).
 2026-11-08 14:19:01 +00:00
ragnarok-clanker
780c281aa2 Maintenance: Name window messaging constants: literal window ids (LookupWindow/EnsureWindow/CloseWindow/... -> WindowId), UIWindowMgr 
Batch #14937 by ragnarok-clanker: no function's compiled code changes; checked with 251 compiled unit(s), including every includer of Source/Client/Mode/ModeMessage.h, Source/Contents/Actors/ActorEnums.h, Source/Network/Packets/PartyJoinPacket.h, Source/UI/Window/UIEnums.h, Source/UI/Window/WindowId.h.
 2026-11-08 13:56:42 +00:00
ragnarok-clanker
503e865c10 Maintenance: Name the CSkillActionMgr dispatchers after the CSkillAction/CEfstAction/CSkillObjectAction virtual each one forwards to 
Batch #14885 by ragnarok-clanker: no function's compiled code changes; checked with 305 compiled unit(s), including every includer of Source/Contents/Skills/SkillInfo.h.
 2026-11-07 23:14:25 +00:00
ragnarok-clanker
ca690786a0 Maintenance: Name the SlotNN virtuals (all 6 families: skill actions, effects, actors, UI extension classes, UIWindow). 191 slots nam 
Batch #14874 by ragnarok-clanker: no function's compiled code changes; checked with 651 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Mode/CMode.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/Npc.h, Source/Contents/Actors/Pc.h, Source/Contents/Actors/RenderObject.h, Source/Contents/Camera/Camera.h, Source/Contents/EffectResourceSwitcher.h, Source/Contents/Effects/AMachineEffect.h, Source/Contents/Effects/AcidifiedThrow.h, Source/Contents/Effects/AnimatedEmitterEffect.h, Source/Contents/Effects/AstralStrikeEffect.h, Source/Contents/Effects/AxeBoomerang.h, Source/Contents/Effects/Bash.h, Source/Contents/Effects/BezierArcThrowEffect.h, Source/Contents/Effects/BindTrapEffect.h, Source/Contents/Effects/BlastForge.h, Source/Contents/Effects/CaneOfEvilEyeEffect.h, Source/Contents/Effects/CartCannon.h, Source/Contents/Effects/CellRangeEffect.h, Source/Contents/Effects/ChangeSizeEffect.h, Source/Contents/Effects/CharacterParticleBundle.h, Source/Contents/Effects/ChargingPierceEffect.h, Source/Contents/Effects/CherryBlossomEffect.h, Source/Contents/Effects/ClimaxEffect.h, Source/Contents/Effects/CloudEffect.h, Source/Contents/Effects/CloudKillEffect.h, Source/Contents/Effects/CommonFloorEffect.h, Source/Contents/Effects/Competentia.h, Source/Contents/Effects/CresciveBolt.h, Source/Contents/Effects/EZ2STREffect.h, Source/Contents/Effects/EZ2STREffectEx.h, Source/Contents/Effects/Effect.h, Source/Contents/Effects/ElectricEffect.h, Source/Contents/Effects/EmitterEffect.h, Source/Contents/Effects/EnergyOrbEffect.h, Source/Contents/Effects/EvilLandEffect.h, Source/Contents/Effects/EvilsPawEffect.h, Source/Contents/Effects/FlowerCastingEffect.h, Source/Contents/Effects/FortuneKissEffect.h, Source/Contents/Effects/FriggSongEffect.h, Source/Contents/Effects/FuumaShouakuEffect.h, Source/Contents/Effects/GlassWallEffect.h, Source/Contents/Effects/GravityControlEffect.h, Source/Contents/Effects/HealEffect.h, Source/Contents/Effects/HealSpEffect.h, Source/Contents/Effects/HitLineEffect.h, Source/Contents/Effects/JupitelThunderStormEffect.h, Source/Contents/Effects/Level150Effect.h, Source/Contents/Effects/Level99Effect.h, Source/Contents/Effects/Level99Orb1Effect.h, Source/Contents/Effects/Level99Orb2Effect.h, Source/Contents/Effects/LightSphereEffect.h, Source/Contents/Effects/MagicFloorEffect.h, Source/Contents/Effects/MagnumBreak.h, Source/Contents/Effects/MapChainEffect.h, Source/Contents/Effects/MapMagicZoneEffect.h, Source/Contents/Effects/MappillarEffect.h, Source/Contents/Effects/MonsterSkillEffects.h, Source/Contents/Effects/NyanggrassEffect.h, Source/Contents/Effects/Particle.h, Source/Contents/Effects/PokJukEffect.h, Source/Contents/Effects/PowderingEffect.h, Source/Contents/Effects/RagEffect.h, Source/Contents/Effects/RainbowEffect.h, Source/Contents/Effects/RectUpEffect.h, Source/Contents/Effects/RedLineEffect.h, Source/Contents/Effects/RichManKim.h, Source/Contents/Effects/RotateBgEffect.h, Source/Contents/Effects/RotateItemEffect.h, Source/Contents/Effects/RotateLineEffect.h, Source/Contents/Effects/SaintCastingEffect.h, Source/Contents/Effects/ScatterEffect.h, Source/Contents/Effects/ShadowExceedEffect.h, Source/Contents/Effects/SkillEffects.h, Source/Contents/Effects/SmokeEffect.h, Source/Contents/Effects/SoulCollectEffect.h, Source/Contents/Effects/SoulUnityEffect.h, Source/Contents/Effects/SphereWind2Effect.h, Source/Contents/Effects/SphereWindEffect.h, Source/Contents/Effects/SpriteEffect.h, Source/Contents/Effects/SquareRangeEffect.h, Source/Contents/Effects/StarEffect.h, Source/Contents/Effects/StarEmperorEffect.h, Source/Contents/Effects/StealEffect.h, Source/Contents/Effects/StormCannonEffect.h, Source/Contents/Effects/StormGustEffect.h, Source/Contents/Effects/StormKickEffect.h, Source/Contents/Effects/SunStanceEffect.h, Source/Contents/Effects/TalismanMarkEffect.h, Source/Contents/Effects/TetraBallEffect.h, Source/Contents/Effects/ThrowEffects.h, Source/Contents/Effects/TriangleShotArrow.h, Source/Contents/Effects/ViolentQuakeEffect.h, Source/Contents/Effects/WindEffect.h, Source/Contents/Ground/GroundGeometry.h, Source/Contents/Messenger/MessengerWindows.h, Source/Contents/SignBoard/SignBoard.h, Source/Contents/Skills/SkillInfo.h, Source/Resource/EmblemResource.h, Source/Resource/GifResource.h, Source/Resource/Resource.h, Source/UI/Acceptance/UIAutoMessageWnd.h, Source/UI/Acceptance/UIJoinPartyAcceptWnd.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Buttons/UIBitmapButton2.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIButton.h, Source/UI/Buttons/UICashEmotionSprBtn.h, Source/UI/Buttons/UICheckBox.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/Buttons/UIItemMoveInfo.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UIJobSlotButton.h, Source/UI/Buttons/UINaviLinkButton.h, Source/UI/Buttons/UIRadioBtn.h, Source/UI/Buttons/UIRadioButton.h, Source/UI/Buttons/UIReplayButton.h, Source/UI/Buttons/UISlotBmpButton.h, Source/UI/Buttons/UISpriteButton.h, Source/UI/Buttons/UITVBitmapButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITagButton.h, Source/UI/Buttons/UITextButton.h, Source/UI/Buttons/UITextureButton.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/CashEmotion/UICashEmotionMiniWnd.h, Source/UI/CashEmotion/UICashEmotionPack.h, Source/UI/CashEmotion/UICashEmotionPiece.h, Source/UI/CashShop/UICashShopWnd.h, Source/UI/Chat/UIChatRoomMakeWnd.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Chat/UISubChatMiniWnd.h, Source/UI/Chat/UIWhisperWnd.h, Source/UI/Clan/UIClanWnd.h, Source/UI/Dialogs/UIBookWnd.h, Source/UI/Dialogs/UIChooseWarpWnd.h, Source/UI/Dialogs/UIChooseWnd.h, Source/UI/Dialogs/UIDisconnectedServerMsgWnd.h, Source/UI/Dialogs/UIEditctrlWnd.h, Source/UI/Dialogs/UIEmailAddressWnd.h, Source/UI/Dialogs/UIGraffiStrboxWnd.h, Source/UI/Dialogs/UILoadingWnd.h, Source/UI/Dialogs/UIMemorialDunWnd.h, Source/UI/Dialogs/UIMenuWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIMinimapZoomWnd.h, Source/UI/Dialogs/UINoticeConfirmWnd.h, Source/UI/Dialogs/UINotifyLevelUpWnd.h, Source/UI/Dialogs/UINotifyQuestWnd.h, Source/UI/Dialogs/UINpcEditDialogWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UIPetTamingDeceiveWnd.h, Source/UI/Dialogs/UIProhibitListWnd.h, Source/UI/Dialogs/UIQuitWnd.h, Source/UI/Dialogs/UIRestartWnd.h, Source/UI/Dialogs/UISayDialogWnd.h, Source/UI/Dialogs/UISelectCartWnd.h, Source/UI/Dialogs/UITipOfTheDayWnd.h, Source/UI/Dialogs/UITipboxWnd.h, Source/UI/Dialogs/UIToolTipWnd.h, Source/UI/Dialogs/UIWaitDBSaveWnd.h, Source/UI/Dialogs/UIWaitWnd.h, Source/UI/Edit/UICandidateWnd.h, Source/UI/Edit/UIEditBoxEx.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIEditCtrl_Currency.h, Source/UI/Emotion/UIEmotionWnd.h, Source/UI/Enchant/EnchantUI.h, Source/UI/EntryQueue/UIEntryQueueWnd.h, Source/UI/Exchange/UIExchangeUI.h, Source/UI/FrameSkin.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Gauges/UIPcGage.h, Source/UI/Guild/UIAgitWnd.h, Source/UI/Guild/UIGuildHelperWnd.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Guild/UIGuild_Storage_Log.h, Source/UI/Item/UIEquipmentPropertiesWnd.h, Source/UI/Item/UIItemBaseWnd.h, Source/UI/Item/UIItemPurchaseWnd.h, Source/UI/Item/UIItemSellWnd.h, Source/UI/Item/UIItemSellWnd2.h, Source/UI/Item/UIItemShopWnd.h, Source/UI/Item/UIItemShopWnd2.h, Source/UI/Item/UIItemStoreFindWnd.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Item/UIItemWnd.h, Source/UI/Item/UIMerchantItemLogWnd.h, Source/UI/Item/UIParaItemShopWnd.h, Source/UI/Items/MergeItemWnd.h, Source/UI/Items/UICardItemIllustWnd.h, Source/UI/Items/UIEquipWnd.h, Source/UI/Items/UIExchangeWnd.h, Source/UI/Items/UIGameItem.h, Source/UI/Items/UIIllustWnd.h, Source/UI/Items/UIItemCollectionWnd.h, Source/UI/Items/UIItemIdentifyWnd.h, Source/UI/Items/UIItemParamChangeDisplayWnd.h, Source/UI/Items/UIItemRepairWnd.h, Source/UI/Items/UIMakeTargetListWnd.h, Source/UI/Items/UIMakeTargetProcessWnd.h, Source/UI/Items/UIMakeTargetResultWnd.h, Source/UI/Items/UINotifyItemObtainWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Items/UIWeaponRefineWnd.h, Source/UI/Lists/TableBox.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UIComboBox.h, Source/UI/Lists/UIComboBoxDefWnd.h, Source/UI/Lists/UIComboBoxEx.h, Source/UI/Lists/UIComboBoxV2Wnd.h, Source/UI/Lists/UIComboBoxWnd.h, Source/UI/Lists/UIImgMenu.h, Source/UI/Lists/UIItemStoreComboBox.h, Source/UI/Lists/UIListBox.h, Source/UI/Lists/UIListBoxEx.h, Source/UI/Lists/UIListBoxID.h, Source/UI/Lists/UIListBoxNavi.h, Source/UI/Lists/UIListBoxNaviSearch.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Lists/UIMemberListBox.h, Source/UI/Lists/UIPackageBoxNameList.h, Source/UI/Lists/UIReplayListBox.h, Source/UI/Lists/UIScrollBar.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITagListBox.h, Source/UI/Lists/UIThumb.h, Source/UI/Lists/UITreeView.h, Source/UI/Lists/UIVScrollBar.h, Source/UI/Menu/UIMenuIconWnd.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/Navigation/UIPrivateAirplaneWnd.h, Source/UI/Party/UIAdvenPartyBoardWnd.h, Source/UI/Party/UIApplyForPartyWnd.h, Source/UI/Party/UIMiniPartyWnd.h, Source/UI/Party/UIPartyInfoWnd.h, Source/UI/Party/UIPartySettingWnd.h, Source/UI/Party/UIRegisterPartyWnd.h, Source/UI/Party/UIRequestJoinPartyWnd.h, Source/UI/ProbabilityTable/UIProbabilityTable.h, Source/UI/Quest/UIOngoingQuestInfo.h, Source/UI/Quest/UIQuestDisplay.h, Source/UI/Quest/UIRecommendedQuestInfo.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Rodex/UIRodexInboxWnd.h, Source/UI/RuneSystem/UIRuneSystemWindows.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/SelectPackageItemBox/SelectPackageItemBox.h, Source/UI/Shop/UIMerchantItemMyShopWnd.h, Source/UI/Shop/UIMerchantItemPurchaseMSGWnd.h, Source/UI/Shop/UIMerchantItemPurchaseWnd.h, Source/UI/Shop/UIMerchantItemShopWnd.h, Source/UI/Shop/UIMerchantItemWnd.h, Source/UI/Shop/UIMerchantMirrorItemWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/Shop/UINoticeMessageBox_LockSellItem.h, Source/UI/Shop/UInCash_CallWnd.h, Source/UI/Shortcuts/UIQuickSlotWnd.h, Source/UI/Shortcuts/UIShortCutWnd.h, Source/UI/Skill/UISkillDescribeWnd.h, Source/UI/Skill/UISkillListWnd.h, Source/UI/Skill/UISkillNameChangeWnd.h, Source/UI/SkillDelayInfo/SkillDelayInfo.h, Source/UI/Status/UIStatusWnd.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/UIAchWnd.h, Source/UI/Text/UIBalloonText.h, Source/UI/Text/UINameBalloonText.h, Source/UI/Text/UIStaticText.h, Source/UI/Text/UIStaticTextControl.h, Source/UI/Text/UIStaticText_LF.h, Source/UI/Text/UIString.h, Source/UI/Text/UITagTextViewer.h, Source/UI/Text/UITextViewer.h, Source/UI/Text/UITextViewerControl.h, Source/UI/Text/UITransBalloonText.h, Source/UI/UIBarGraph.h, Source/UI/UIBartermarketWnd.h, Source/UI/UIBasicCtrl.h, Source/UI/UIBroadcastBalloon.h, Source/UI/UICaptchaPreviewWnd.h, Source/UI/UICaptchaRegisterWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UICheckAttendanceWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UIHotkeyGuideWnd.h, Source/UI/UIIngredientInfoWnd.h, Source/UI/UIItemReformWnd.h, Source/UI/UILapineScrollBar.h, Source/UI/UILapineUpgradeBoxWnd.h, Source/UI/UIMacroBlackListCheckWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIMacroReport.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/UIPreviewEquipWnd.h, Source/UI/UIRefiningWnd.h, Source/UI/UIReputeWnd.h, Source/UI/UIRoundBoxTooltipWnd.h, Source/UI/UIScrollWnd.h, Source/UI/UISlotBitmap.h, Source/UI/UIStaticBitmap.h, Source/UI/UIStaticItem.h, Source/UI/Window/UIAccountLimitedToolWnd.h, Source/UI/Window/UIBalloonOpenBtn.h, Source/UI/Window/UIBank_NewWnd.h, Source/UI/Window/UIBasicInfoWnd.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UIBitmapTab.h, Source/UI/Window/UIChangeNameWnd.h, Source/UI/Window/UIChatRoomWnd.h, Source/UI/Window/UICntWnd.h, Source/UI/Window/UICollectionSystemWnd.h, Source/UI/Window/UIControl.h, Source/UI/Window/UIDebuffRemoveWnd.h, Source/UI/Window/UIEmblemWnd.h, Source/UI/Window/UIEscOptionWnd.h, Source/UI/Window/UIFrameWnd.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginOTPWnd.h, Source/UI/Window/UILoginWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMerInfoWnd.h, Source/UI/Window/UIMessageBox.h, Source/UI/Window/UIMessageBoxAutoreturn.h, Source/UI/Window/UIMileageWnd.h, Source/UI/Window/UIMiniBtnWnd.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UIMonsterInfoWnd.h, Source/UI/Window/UINavigationHelpWnd.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UINoteWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIOpenMailBoxWnd.h, Source/UI/Window/UIOpenRoulletteWnd.h, Source/UI/Window/UIPartyBookingHelpWnd.h, Source/UI/Window/UIPetEvolutionWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIRebirthWnd.h, Source/UI/Window/UIReplayControlWnd.h, Source/UI/Window/UIReplayRECControlWnd.h, Source/UI/Window/UIResizer.h, Source/UI/Window/UIRoMapWnd.h, Source/UI/Window/UIRodexContentsWnd.h, Source/UI/Window/UIRoulletteWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyListWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UISelectReplayDataWnd.h, Source/UI/Window/UISelectServerWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UIShowWarpWnd.h, Source/UI/Window/UITab.h, Source/UI/Window/UITalkboxTrapInputWnd.h, Source/UI/Window/UITransMenuWnd.h, Source/UI/Window/UIVideoWnd.h, Source/UI/Window/UIViewCameraInfoWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWordDisplayWnd.h.
 2026-11-07 21:38:02 +00:00
ragnarok-clanker
13ef1172af Decompile 4 functions in Source/Contents/Skills/SkillInfo.cpp 
Batch #13522 by cremane: 0 byte-identical, 4 confirmed by peer review.

- fn_08341 CSkillAction_AG_ENERGY_CONVERSION::Slot11: logic confirmed by peer review
- fn_08393 CSkillAction_IQ_BLAZING_FLAME_BLAST::Slot11: logic confirmed by peer review
- fn_08449 DustExplosionSpawner::operator(): logic confirmed by peer review
- fn_08480 CSkillAction_DK_DRAGONIC_PIERCE::Slot11: logic confirmed by peer review

Peer-reviewed-by: eAthena, Toshiro, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-06 20:13:50 +00:00
ragnarok-clanker
237a4b2003 Decompile 32 functions in Source/Contents/Skills/SkillInfo.cpp 
Batch #13402 by cremane: 0 byte-identical, 32 confirmed by peer review.

- fn_08451 CEfstAction_VIGOR::Slot00: logic confirmed by peer review
- fn_08456 CSkillAction_DK_SERVANTWEAPON_ATK::Slot15: logic confirmed by peer review
- fn_08457 CSkillAction_DK_SERVANTWEAPON_ATK::Slot16: logic confirmed by peer review
- fn_08462 CEfstAction_SERVANT_SIGN::Slot00: logic confirmed by peer review
- fn_08471 CSkillAction_DK_SERVANT_W_DEMOL::Slot16: logic confirmed by peer review
- fn_08473 CSkillAction_DK_STORMSLASH::Slot11: logic confirmed by peer review
- fn_08477 CSkillAction_DK_MADNESS_CRUSHER::Slot16: logic confirmed by peer review
- fn_08479 CSkillAction_DK_DRAGONIC_PIERCE::Slot08: logic confirmed by peer review
- fn_08481 CSkillAction_DK_DRAGONIC_PIERCE::Slot16: logic confirmed by peer review
- fn_08484 CSkillAction_DK_DRAGONIC_BREATH::Slot11: logic confirmed by peer review
- fn_08488 CSkillAction_DK_CHARGINGPIERCE::Slot11: logic confirmed by peer review
- fn_08490 CEfstAction_CHARGINGPIERCE_COUNT::Slot00: logic confirmed by peer review
- fn_08493 CSkillAction_DK_HACKANDSLASHER::Slot11: logic confirmed by peer review
- fn_08494 CSkillAction_DK_HACKANDSLASHER::Slot16: logic confirmed by peer review
- fn_08496 CSkillAction_DK_HACKANDSLASHER_ATK::Slot16: logic confirmed by peer review
- fn_08506 CSkillAction_NPC_LIGHTNING_JUDGEMENT::Slot11: logic confirmed by peer review
- fn_08508 CEfstAction_GROGGY::Slot00: logic confirmed by peer review
- fn_08512 CEfstAction_TARGET_MARKER::Slot00: logic confirmed by peer review
- fn_08522 CEfstAction_BLOCK_SEAL::Slot00: logic confirmed by peer review
- fn_08527 CSkillAction_HN_DOUBLEBOWLINGBASH::Slot11: logic confirmed by peer review
- fn_08530 CSkillAction_HN_MEGA_SONIC_BLOW::Slot11: logic confirmed by peer review
- fn_08533 CSkillAction_HN_SHIELD_CHAIN_RUSH::Slot11: logic confirmed by peer review
- fn_08536 CSkillAction_HN_SPIRAL_PIERCE_MAX::Slot11: logic confirmed by peer review
- fn_08550 CSkillObjectAction_HN_JACK_FROST_NOVA::Slot00: logic confirmed by peer review
- fn_08551 CSkillObjectAction_HN_JACK_FROST_NOVA::Slot01: logic confirmed by peer review
- fn_08558 CSkillObjectAction_HN_GROUND_GRAVITATION::Slot00: logic confirmed by peer review
- fn_08562 CSkillAction_HN_NAPALM_VULCAN_STRIKE::Slot15: logic confirmed by peer review
- fn_08565 CSkillAction_HN_BREAKINGLIMIT::Slot11: logic confirmed by peer review
- fn_08566 CEfstAction_BREAKINGLIMIT::Slot00: logic confirmed by peer review
- fn_08571 CSkillAction_HN_RULEBREAK::Slot11: logic confirmed by peer review
- fn_08572 CEfstAction_RULEBREAK::Slot00: logic confirmed by peer review
- fn_08575 CSkillAction_HN_OVERCOMING_CRISIS::Slot11: logic confirmed by peer review

Peer-reviewed-by: Tanke, Toshiro, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-06 15:39:33 +00:00
ragnarok-clanker
5b97ec90e2 Decompile 36 functions in Source/Contents/Skills/SkillInfo.cpp 
Batch #13390 by cremane: 0 byte-identical, 36 confirmed by peer review.

- fn_08337 CEfstAction_UNLIMIT::Slot00: logic confirmed by peer review
- fn_08336 CSkillAction_RA_UNLIMIT::Slot11: logic confirmed by peer review
- fn_08342 CSkillAction_CD_DIVINUS_FLOS::Slot08: logic confirmed by peer review
- fn_08343 CSkillAction_CD_DIVINUS_FLOS::Slot11: logic confirmed by peer review
- fn_08345 CSkillAction_SHC_ENCHANTING_SHADOW::Slot08: logic confirmed by peer review
- fn_08349 CSkillAction_SHC_IMPACT_CRATER::Slot11: logic confirmed by peer review
- fn_08350 CSkillAction_SHC_IMPACT_CRATER::Slot16: logic confirmed by peer review
- fn_08352 CSkillAction_SHC_CROSS_SLASH::Slot11: logic confirmed by peer review
- fn_08353 CSkillAction_SHC_CROSS_SLASH::Slot16: logic confirmed by peer review
- fn_08355 CSkillAction_SHC_DANCING_KNIFE::Slot08: logic confirmed by peer review
- fn_08356 CSkillAction_SHC_DANCING_KNIFE::Slot16: logic confirmed by peer review
- fn_08363 CSkillAction_SHC_SHADOW_EXCEED::Slot08: logic confirmed by peer review
- fn_08373 CSkillAction_ABC_CHASING_BREAK::Slot16: logic confirmed by peer review
- fn_08376 CSkillAction_ABC_CHASING_SHOT::Slot08: logic confirmed by peer review
- fn_08378 CSkillAction_ABC_CHASING_SHOT::Slot15: logic confirmed by peer review
- fn_08379 CSkillAction_ABC_CHASING_SHOT::Slot16: logic confirmed by peer review
- fn_08381 CSkillAction_ABC_HIT_AND_SLIDING::Slot16: logic confirmed by peer review
- fn_08382 CSkillAction_ABC_ABYSS_FLAME::Slot08: logic confirmed by peer review
- fn_08383 CSkillAction_ABC_ABYSS_FLAME::Slot11: logic confirmed by peer review
- fn_08384 CSkillAction_ABC_ABYSS_FLAME::Slot16: logic confirmed by peer review
- fn_08386 CSkillAction_ABC_ABYSS_FLAME_ATK::Slot11: logic confirmed by peer review
- fn_08387 CSkillAction_ABC_ABYSS_FLAME_ATK::Slot16: logic confirmed by peer review
- fn_08388 CSkillAction_EM_PSYCHIC_STREAM::Slot08: logic confirmed by peer review
- fn_08389 CSkillAction_EM_PSYCHIC_STREAM::Slot11: logic confirmed by peer review
- fn_08390 CSkillAction_EM_PSYCHIC_STREAM::Slot16: logic confirmed by peer review
- fn_08392 CSkillAction_IQ_BLAZING_FLAME_BLAST::Slot08: logic confirmed by peer review
- fn_08329 CEfstAction_GenderChange::Slot00: logic confirmed by peer review
- fn_08357 CEfstAction_DANCING_KNIFE::Slot00: logic confirmed by peer review
- fn_08361 CSkillAction_SHC_SHADOW_STAB::Slot11: logic confirmed by peer review
- fn_08438 CSkillAction_BO_MAYHEMIC_THORNS::Slot11: logic confirmed by peer review
- fn_08440 CSkillAction_BO_EXPLOSIVE_POWDER::Slot11: logic confirmed by peer review
- fn_08442 CSkillAction_BO_MYSTERY_POWDER::Slot11: logic confirmed by peer review
- fn_08443 CSkillAction_BO_MYSTERY_POWDER::Slot16: logic confirmed by peer review
- fn_08444 CEfstAction_MYSTERY_POWDER::Slot00: logic confirmed by peer review
- fn_08448 CSkillAction_BO_DUST_EXPLOSION::Slot16: logic confirmed by peer review
- fn_08450 CSkillAction_DK_VIGOR::Slot11: logic confirmed by peer review

Peer-reviewed-by: Tanke, Toshiro, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-06 15:22:02 +00:00
ragnarok-clanker
aee4618579 Decompile 11 functions in Source/Contents/Skills/SkillInfo.cpp 
Batch #13323 by cremane: 11 byte-identical, 0 confirmed by peer review.

- fn_08338 CEfstAction_UNLIMIT::Slot01: byte-identical
- fn_08358 CEfstAction_DANCING_KNIFE::Slot01: byte-identical
- fn_08445 CEfstAction_MYSTERY_POWDER::Slot01: byte-identical
- fn_08452 CEfstAction_VIGOR::Slot01: byte-identical
- fn_08463 CEfstAction_SERVANT_SIGN::Slot01: byte-identical
- fn_08509 CEfstAction_GROGGY::Slot01: byte-identical
- fn_08513 CEfstAction_TARGET_MARKER::Slot01: byte-identical
- fn_08523 CEfstAction_BLOCK_SEAL::Slot01: byte-identical
- fn_08559 CSkillObjectAction_HN_GROUND_GRAVITATION::Slot01: byte-identical
- fn_08567 CEfstAction_BREAKINGLIMIT::Slot01: byte-identical
- fn_08573 CEfstAction_RULEBREAK::Slot01: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-11-06 12:56:54 +00:00
ragnarok-clanker
66113bd23b Decompile 2 functions in Source/Contents/Skills/SkillInfo.cpp 
Batch #13059 by aDw: 0 byte-identical, 2 confirmed by peer review.

- fn_08447 CSkillAction_BO_DUST_EXPLOSION::Slot11: logic confirmed by peer review
- fn_08449 DustExplosionSpawner::operator(): logic confirmed by peer review

Peer-reviewed-by: gordaoprogramas, cremane, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-06 04:45:33 +00:00
ragnarok-clanker
70dc663563 Decompile 9 functions in Source/Contents/Skills/SkillInfo.cpp 
Batch #11862 by Yommy: 0 byte-identical, 9 confirmed by peer review.

- fn_08404 CSkillActionMgr::ActionSlot01: logic confirmed by peer review
- fn_08408 CSkillActionMgr::ActionSlot14: logic confirmed by peer review
- fn_08411 CSkillActionMgr::ActionSlot04: logic confirmed by peer review
- fn_08413 CSkillActionMgr::IsSupportAction: logic confirmed by peer review
- fn_08422 CSkillActionMgr::ActionSlot10: logic confirmed by peer review
- fn_08423 CSkillActionMgr::EfstSlot01: logic confirmed by peer review
- fn_08424 CSkillActionMgr::ActionSlot12: logic confirmed by peer review
- fn_08425 CSkillActionMgr::ActionSlot15: logic confirmed by peer review
- fn_08428 CSkillActionMgr::ObjectSlot00: logic confirmed by peer review

Peer-reviewed-by: KWDev, SapitoSucio, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-05 11:41:10 +00:00
ragnarok-clanker
69342a6e6c Decompile 17 functions in Source/Contents/Skills/SkillInfo.cpp 
Batch #11864 by Yommy: 2 byte-identical, 15 confirmed by peer review.

- fn_08321 HidesUseFailureMessage: byte-identical
- fn_08406 CSkillActionMgr::EfstSlot03: logic confirmed by peer review
- fn_08407 CSkillActionMgr::EfstSlot04: logic confirmed by peer review
- fn_08409 CSkillActionMgr::ActionSlot02: logic confirmed by peer review
- fn_08410 CSkillActionMgr::ActionSlot03: logic confirmed by peer review
- fn_08412 CSkillActionMgr::HasEfstAction: byte-identical
- fn_08414 CSkillActionMgr::ActionSlot07: logic confirmed by peer review
- fn_08415 CSkillActionMgr::ActionSlot06: logic confirmed by peer review
- fn_08416 CSkillActionMgr::ActionSlot13: logic confirmed by peer review
- fn_08417 CSkillActionMgr::ActionSlot05: logic confirmed by peer review
- fn_08418 CSkillActionMgr::ActionSlot16: logic confirmed by peer review
- fn_08419 CSkillActionMgr::EfstSlot00: logic confirmed by peer review
- fn_08420 CSkillActionMgr::ActionSlot08: logic confirmed by peer review
- fn_08421 CSkillActionMgr::ActionSlot09: logic confirmed by peer review
- fn_08426 CSkillActionMgr::EfstSlot02: logic confirmed by peer review
- fn_08427 CSkillActionMgr::ObjectSlot01: logic confirmed by peer review
- fn_08429 CSkillActionMgr::ActionSlot11: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-05 05:08:38 +00:00
ragnarok-clanker
148e3b4c6c Decompile 2 functions in Source/Contents/Skills/SkillInfo.cpp 
Batch #11244 by cremane: 0 byte-identical, 2 confirmed by peer review.

- fn_08254 CSkillInfo::CSkillInfo: logic confirmed by peer review
- fn_12543 CSkillInfo::operator=: logic confirmed by peer review

Peer-reviewed-by: Yommy, dori, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-05 00:13:05 +00:00
ragnarok-clanker
ba6ca37fa1 Maintenance: [forced, user-approved] Family G32: remove TerrainHeight (31 files, reassigned from agent 2). The height-grid methods ru 
Batch #10268 by ragnarok-clanker: forced by an admin (17 lower score(s), 85 changed function(s)); checked with 222 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Contents/Camera/CameraFrame.h, Source/Contents/Ground/TerrainHeight.h, Source/Contents/World/World.h, Source/Resource/World/TerrainResource.h.
 2026-11-03 14:34:33 +00:00
ragnarok-clanker
3be8819db2 Maintenance: [forced, user-approved] Family W4: remove invented EffectAttachments (reference bundle over EffectActorState effects/fir 
Batch #10257 by ragnarok-clanker: forced by an admin (7 lower score(s), 31 changed function(s)); checked with 95 compiled unit(s), including every includer of Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectAttachments.h.
Deletes: Source/Contents/Effects/EffectAttachments.h
 2026-11-03 13:09:24 +00:00
ragnarok-clanker
d66aa056a4 Decompile fn_08576 (CSkillObjectActionRegistration::CSkillObjectActionRegistration) 
Batch #9849 by ntrl: 0 byte-identical, 1 confirmed by peer review.

- fn_08576 CSkillObjectActionRegistration::CSkillObjectActionRegistration: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, KWDev, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-02 02:54:21 +00:00
ragnarok-clanker
e0d25b6324 Decompile fn_03339 (CSkillActionMgr::GetInstance) 
Batch #9851 by ntrl: 0 byte-identical, 1 confirmed by peer review.

- fn_03339 CSkillActionMgr::GetInstance: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-02 02:50:16 +00:00
ragnarok-clanker
a9d8e11f54 Maintenance: Replace raw call 0x00CDFA00 in CSkillAction_HN_JACK_FROST_NOVA::Slot10 with CGameMode::LaunchDummyEffect (fn_21324, CGam 
Batch #8882 by ragnarok-clanker: forced by an admin (0 lower score(s), 1 changed function(s)); checked with 1 compiled unit(s).
 2026-10-31 22:14:23 +00:00
ragnarok-clanker
37ca1a0b36 Decompile fn_08551 (CSkillObjectAction_HN_JACK_FROST_NOVA::Slot01) 
Batch #7852 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_08551 CSkillObjectAction_HN_JACK_FROST_NOVA::Slot01: logic confirmed by peer review

Peer-reviewed-by: secret, Tanke, pedrao
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-31 12:19:44 +00:00
ragnarok-clanker
7c1d45f716 Decompile fn_08461 (CSkillAction_DK_SERVANT_W_PHANTOM::Slot16) 
Batch #6689 by Tanke: 0 byte-identical, 1 confirmed by peer review.

- fn_08461 CSkillAction_DK_SERVANT_W_PHANTOM::Slot16: logic confirmed by peer review

Peer-reviewed-by: eAthena, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-31 01:39:36 +00:00
ragnarok-clanker
bdb7729189 Decompile 2 functions in Source/Contents/Skills/SkillInfo.cpp 
Batch #6272 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_08332 CEfstAction_ShowEffect::Slot00: logic confirmed by peer review
- fn_08333 CEfstAction_ShowEffect::Slot01: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, superintelligence, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-30 21:13:37 +00:00
ragnarok-clanker
16f7fac1dc Decompile fn_08548 (CSkillAction_HN_JACK_FROST_NOVA::Slot10) 
Batch #5951 by Tanke: 0 byte-identical, 1 confirmed by peer review.

- fn_08548 CSkillAction_HN_JACK_FROST_NOVA::Slot10: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, ntrl, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-30 17:53:59 +00:00
ragnarok-clanker
3c5ebdc341 Decompile 5 functions in Source/Contents/Skills/SkillInfo.cpp 
Batch #5261 by eAthena: 0 byte-identical, 5 confirmed by peer review.

- fn_08361 CSkillAction_SHC_SHADOW_STAB::Slot11: logic confirmed by peer review
- fn_08480 CSkillAction_DK_DRAGONIC_PIERCE::Slot11: logic confirmed by peer review
- fn_08490 CEfstAction_CHARGINGPIERCE_COUNT::Slot00: logic confirmed by peer review
- fn_08554 CSkillAction_HN_HELLS_DRIVE::Slot11: logic confirmed by peer review
- fn_08577 `CSkillAction_HN_HELLS_DRIVE::Slot11'::`2'::<lambda_1>::operator(): logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, meitogi, tayoba
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-30 10:26:53 +00:00
ragnarok-clanker
1563aef436 Decompile fn_08562 (CSkillAction_HN_NAPALM_VULCAN_STRIKE::Slot15) 
Batch #4126 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_08562 CSkillAction_HN_NAPALM_VULCAN_STRIKE::Slot15: logic confirmed by peer review

Peer-reviewed-by: alisonrag, superintelligence, tayoba
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-30 02:26:31 +00:00
ragnarok-clanker
adaa46c8c7 Decompile 75 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/Skills/SkillActionImperialGuard.cpp 
Batch #4284 by eAthena: 18 byte-identical, 57 confirmed by peer review.

- fn_08505 CSkillAction_NPC_LIGHTNING_JUDGEMENT::Slot08: logic confirmed by peer review
- fn_08506 CSkillAction_NPC_LIGHTNING_JUDGEMENT::Slot11: logic confirmed by peer review
- fn_08507 CSkillAction_NPC_LIGHTNING_JUDGEMENT::Slot16: logic confirmed by peer review
- fn_08508 CEfstAction_GROGGY::Slot00: logic confirmed by peer review
- fn_08509 CEfstAction_GROGGY::Slot01: logic confirmed by peer review
- fn_08510 CEfstAction_GROGGY::Slot02: logic confirmed by peer review
- fn_08511 CSkillAction_NPC_RESET_EFST::Slot11: logic confirmed by peer review
- fn_08512 CEfstAction_TARGET_MARKER::Slot00: logic confirmed by peer review
- fn_08513 CEfstAction_TARGET_MARKER::Slot01: logic confirmed by peer review
- fn_08514 CEfstAction_TARGET_MARKER::Slot02: logic confirmed by peer review
- fn_08516 CSkillAction_NPC_AIMED_SHOWER::Slot08: logic confirmed by peer review
- fn_08517 CSkillAction_NPC_AIMED_SHOWER::Slot11: logic confirmed by peer review
- fn_08518 CSkillAction_NPC_AIMED_SHOWER::Slot16: logic confirmed by peer review
- fn_08519 CSkillAction_NPC_BLAZING_ERUPTION::Slot08: logic confirmed by peer review
- fn_08520 CSkillAction_NPC_BLAZING_ERUPTION::Slot11: logic confirmed by peer review
- fn_08521 CSkillAction_NPC_BLOCK_SEAL::Slot08: logic confirmed by peer review
- fn_08522 CEfstAction_BLOCK_SEAL::Slot00: logic confirmed by peer review
- fn_08523 CEfstAction_BLOCK_SEAL::Slot01: logic confirmed by peer review
- fn_08524 CEfstAction_BLOCK_SEAL::Slot02: logic confirmed by peer review
- fn_08525 CSkillAction_HN_DOUBLEBOWLINGBASH::Slot02: byte-identical
- fn_08526 CSkillAction_HN_DOUBLEBOWLINGBASH::Slot08: logic confirmed by peer review
- fn_08527 CSkillAction_HN_DOUBLEBOWLINGBASH::Slot11: logic confirmed by peer review
- fn_08528 CSkillAction_HN_DOUBLEBOWLINGBASH::Slot16: logic confirmed by peer review
- fn_08529 CSkillAction_HN_MEGA_SONIC_BLOW::Slot02: byte-identical
- fn_08530 CSkillAction_HN_MEGA_SONIC_BLOW::Slot11: logic confirmed by peer review
- fn_08531 CSkillAction_HN_SHIELD_CHAIN_RUSH::Slot02: byte-identical
- fn_08532 CSkillAction_HN_SHIELD_CHAIN_RUSH::Slot08: logic confirmed by peer review
- fn_08533 CSkillAction_HN_SHIELD_CHAIN_RUSH::Slot11: logic confirmed by peer review
- fn_08534 CSkillAction_HN_SPIRAL_PIERCE_MAX::Slot02: byte-identical
- fn_08535 CSkillAction_HN_SPIRAL_PIERCE_MAX::Slot08: logic confirmed by peer review
- fn_08536 CSkillAction_HN_SPIRAL_PIERCE_MAX::Slot11: logic confirmed by peer review
- fn_08537 CSkillAction_HN_METEOR_STORM_BUSTER::Slot03: byte-identical
- fn_08538 CSkillAction_HN_METEOR_STORM_BUSTER::Slot08: logic confirmed by peer review
- fn_08539 CSkillAction_HN_METEOR_STORM_BUSTER::Slot12: logic confirmed by peer review
- fn_08540 CSkillAction_HN_METEOR_STORM_BUSTER::Slot13: byte-identical
- fn_08541 CSkillAction_HN_METEOR_STORM_BUSTER::Slot14: byte-identical
- fn_08542 CSkillAction_HN_JUPITEL_THUNDER_STORM::Slot02: byte-identical
- fn_08543 CSkillAction_HN_JUPITEL_THUNDER_STORM::Slot08: logic confirmed by peer review
- fn_08544 CSkillAction_HN_JUPITEL_THUNDER_STORM::Slot11: logic confirmed by peer review
- fn_08545 CSkillAction_HN_JACK_FROST_NOVA::Slot02: byte-identical
- fn_08546 CSkillAction_HN_JACK_FROST_NOVA::Slot03: byte-identical
- fn_08547 CSkillAction_HN_JACK_FROST_NOVA::Slot08: logic confirmed by peer review
- fn_08549 CSkillAction_HN_JACK_FROST_NOVA::Slot14: byte-identical
- fn_08550 CSkillObjectAction_HN_JACK_FROST_NOVA::Slot00: logic confirmed by peer review
- fn_08552 CSkillAction_HN_HELLS_DRIVE::Slot02: byte-identical
- fn_08553 CSkillAction_HN_HELLS_DRIVE::Slot08: logic confirmed by peer review
- fn_08555 CSkillAction_HN_GROUND_GRAVITATION::Slot02: byte-identical
- fn_08556 CSkillAction_HN_GROUND_GRAVITATION::Slot03: byte-identical
- fn_08557 CSkillAction_HN_GROUND_GRAVITATION::Slot08: logic confirmed by peer review
- fn_08558 CSkillObjectAction_HN_GROUND_GRAVITATION::Slot00: logic confirmed by peer review
- fn_08559 CSkillObjectAction_HN_GROUND_GRAVITATION::Slot01: logic confirmed by peer review
- fn_08560 CSkillAction_HN_NAPALM_VULCAN_STRIKE::Slot02: byte-identical
- fn_08561 CSkillAction_HN_NAPALM_VULCAN_STRIKE::Slot08: logic confirmed by peer review
- fn_08563 CSkillAction_HN_BREAKINGLIMIT::Slot02: byte-identical
- fn_08564 CSkillAction_HN_BREAKINGLIMIT::Slot08: logic confirmed by peer review
- fn_08565 CSkillAction_HN_BREAKINGLIMIT::Slot11: logic confirmed by peer review
- fn_08566 CEfstAction_BREAKINGLIMIT::Slot00: logic confirmed by peer review
- fn_08567 CEfstAction_BREAKINGLIMIT::Slot01: logic confirmed by peer review
- fn_08568 CEfstAction_BREAKINGLIMIT::Slot02: logic confirmed by peer review
- fn_08569 CSkillAction_HN_RULEBREAK::Slot02: byte-identical
- fn_08570 CSkillAction_HN_RULEBREAK::Slot08: logic confirmed by peer review
- fn_08571 CSkillAction_HN_RULEBREAK::Slot11: logic confirmed by peer review
- fn_08572 CEfstAction_RULEBREAK::Slot00: logic confirmed by peer review
- fn_08573 CEfstAction_RULEBREAK::Slot01: logic confirmed by peer review
- fn_08574 CEfstAction_RULEBREAK::Slot02: logic confirmed by peer review
- fn_08575 CSkillAction_HN_OVERCOMING_CRISIS::Slot11: logic confirmed by peer review
- fn_08579 CSkillAction_IG_CROSS_RAIN::Slot08: logic confirmed by peer review
- fn_08580 CSkillAction_IG_CROSS_RAIN::Slot14: byte-identical
- fn_08581 CSkillObjectAction_IG_CROSS_RAIN::Slot00: logic confirmed by peer review
- fn_08583 CSkillAction_IG_GRAND_JUDGEMENT::Slot08: logic confirmed by peer review
- fn_08584 CSkillAction_IG_GRAND_JUDGEMENT::Slot11: logic confirmed by peer review
- fn_08585 CEfstAction_IG_GRAND_JUDGEMENT::Slot00: logic confirmed by peer review
- fn_08586 CEfstAction_IG_GRAND_JUDGEMENT::Slot01: logic confirmed by peer review
- fn_08587 CEfstAction_IG_GRAND_JUDGEMENT::Slot02: logic confirmed by peer review
- fn_08589 CSkillAction_IG_GUARDIAN_SHIELD::Slot08: logic confirmed by peer review

Peer-reviewed-by: youko, superintelligence, ragnarok-clanker, tayoba
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-30 02:00:57 +00:00
ragnarok-clanker
89336cf88f Decompile fn_03339 (CSkillActionMgr::GetInstance) 
Batch #3776 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_03339 CSkillActionMgr::GetInstance: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-29 23:38:45 +00:00
ragnarok-clanker
cbde2b8c67 Decompile fn_08499 (CSkillAction_NPC_FROST_FIELD::Slot08) 
Batch #3659 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_08499 CSkillAction_NPC_FROST_FIELD::Slot08: logic confirmed by peer review

Peer-reviewed-by: Yommy, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-29 22:59:06 +00:00
ragnarok-clanker
311ae95e21 Decompile 70 functions in Source/Contents/Skills/SkillInfo.cpp 
Batch #3629 by eAthena: 0 byte-identical, 70 confirmed by peer review.

- fn_08414 CSkillActionMgr::ActionSlot07: logic confirmed by peer review
- fn_08415 CSkillActionMgr::ActionSlot06: logic confirmed by peer review
- fn_08416 CSkillActionMgr::ActionSlot13: logic confirmed by peer review
- fn_08417 CSkillActionMgr::ActionSlot05: logic confirmed by peer review
- fn_08418 CSkillActionMgr::ActionSlot16: logic confirmed by peer review
- fn_08419 CSkillActionMgr::EfstSlot00: logic confirmed by peer review
- fn_08420 CSkillActionMgr::ActionSlot08: logic confirmed by peer review
- fn_08421 CSkillActionMgr::ActionSlot09: logic confirmed by peer review
- fn_08422 CSkillActionMgr::ActionSlot10: logic confirmed by peer review
- fn_08423 CSkillActionMgr::EfstSlot01: logic confirmed by peer review
- fn_08424 CSkillActionMgr::ActionSlot12: logic confirmed by peer review
- fn_08425 CSkillActionMgr::ActionSlot15: logic confirmed by peer review
- fn_08426 CSkillActionMgr::EfstSlot02: logic confirmed by peer review
- fn_08427 CSkillActionMgr::ObjectSlot01: logic confirmed by peer review
- fn_08428 CSkillActionMgr::ObjectSlot00: logic confirmed by peer review
- fn_08429 CSkillActionMgr::ActionSlot11: logic confirmed by peer review
- fn_08430 CSkillActionMgr::RegisterEfstAction: logic confirmed by peer review
- fn_08431 CSkillActionMgr::RegisterSkillObjectAction: logic confirmed by peer review
- fn_08432 CSkillActionMgr::RegisterSkillAction: logic confirmed by peer review
- fn_08437 CSkillAction_BO_MAYHEMIC_THORNS::Slot08: logic confirmed by peer review
- fn_08438 CSkillAction_BO_MAYHEMIC_THORNS::Slot11: logic confirmed by peer review
- fn_08440 CSkillAction_BO_EXPLOSIVE_POWDER::Slot11: logic confirmed by peer review
- fn_08442 CSkillAction_BO_MYSTERY_POWDER::Slot11: logic confirmed by peer review
- fn_08443 CSkillAction_BO_MYSTERY_POWDER::Slot16: logic confirmed by peer review
- fn_08444 CEfstAction_MYSTERY_POWDER::Slot00: logic confirmed by peer review
- fn_08445 CEfstAction_MYSTERY_POWDER::Slot01: logic confirmed by peer review
- fn_08446 CEfstAction_MYSTERY_POWDER::Slot02: logic confirmed by peer review
- fn_08447 CSkillAction_BO_DUST_EXPLOSION::Slot11: logic confirmed by peer review
- fn_08448 CSkillAction_BO_DUST_EXPLOSION::Slot16: logic confirmed by peer review
- fn_08449 SpawnDustExplosion: logic confirmed by peer review
- fn_08450 CSkillAction_DK_VIGOR::Slot11: logic confirmed by peer review
- fn_08451 CEfstAction_VIGOR::Slot00: logic confirmed by peer review
- fn_08452 CEfstAction_VIGOR::Slot01: logic confirmed by peer review
- fn_08453 CEfstAction_VIGOR::Slot02: logic confirmed by peer review
- fn_08454 CEfstAction_VIGOR::Slot04: logic confirmed by peer review
- fn_08456 CSkillAction_DK_SERVANTWEAPON_ATK::Slot15: logic confirmed by peer review
- fn_08457 CSkillAction_DK_SERVANTWEAPON_ATK::Slot16: logic confirmed by peer review
- fn_08458 CEfstAction_SERVANTWEAPON::Slot01: logic confirmed by peer review
- fn_08459 CEfstAction_SERVANTWEAPON::Slot04: logic confirmed by peer review
- fn_08462 CEfstAction_SERVANT_SIGN::Slot00: logic confirmed by peer review
- fn_08463 CEfstAction_SERVANT_SIGN::Slot01: logic confirmed by peer review
- fn_08464 CEfstAction_SERVANT_SIGN::Slot02: logic confirmed by peer review
- fn_08466 CSkillAction_DK_SERVANT_W_PHANTOM::Slot08: logic confirmed by peer review
- fn_08467 CSkillAction_DK_SERVANT_W_PHANTOM::Slot11: logic confirmed by peer review
- fn_08468 CSkillAction_DK_SERVANT_W_PHANTOM::Slot15: logic confirmed by peer review
- fn_08469 CSkillAction_DK_SERVANT_W_DEMOL::Slot11: logic confirmed by peer review
- fn_08470 CSkillAction_DK_SERVANT_W_DEMOL::Slot15: logic confirmed by peer review
- fn_08471 CSkillAction_DK_SERVANT_W_DEMOL::Slot16: logic confirmed by peer review
- fn_08473 CSkillAction_DK_STORMSLASH::Slot11: logic confirmed by peer review
- fn_08476 CSkillAction_DK_MADNESS_CRUSHER::Slot08: logic confirmed by peer review
- fn_08477 CSkillAction_DK_MADNESS_CRUSHER::Slot16: logic confirmed by peer review
- fn_08479 CSkillAction_DK_DRAGONIC_PIERCE::Slot08: logic confirmed by peer review
- fn_08481 CSkillAction_DK_DRAGONIC_PIERCE::Slot16: logic confirmed by peer review
- fn_08483 CSkillAction_DK_DRAGONIC_BREATH::Slot08: logic confirmed by peer review
- fn_08484 CSkillAction_DK_DRAGONIC_BREATH::Slot11: logic confirmed by peer review
- fn_08485 CSkillAction_DK_DRAGONIC_BREATH::Slot15: logic confirmed by peer review
- fn_08487 CSkillAction_DK_CHARGINGPIERCE::Slot08: logic confirmed by peer review
- fn_08488 CSkillAction_DK_CHARGINGPIERCE::Slot11: logic confirmed by peer review
- fn_08489 CEfstAction_CHARGINGPIERCE::Slot04: logic confirmed by peer review
- fn_08491 CEfstAction_CHARGINGPIERCE_COUNT::Slot01: logic confirmed by peer review
- fn_08493 CSkillAction_DK_HACKANDSLASHER::Slot11: logic confirmed by peer review
- fn_08494 CSkillAction_DK_HACKANDSLASHER::Slot16: logic confirmed by peer review
- fn_08496 CSkillAction_DK_HACKANDSLASHER_ATK::Slot16: logic confirmed by peer review
- fn_08497 CSkillAction_NPC_BLOCK_EXPLOSION::Slot08: logic confirmed by peer review
- fn_08498 CSkillAction_NPC_BLOCK_EXPLOSION::Slot11: logic confirmed by peer review
- fn_08500 CSkillAction_NPC_FROST_FIELD::Slot11: logic confirmed by peer review
- fn_08501 CSkillAction_NPC_FROST_FIELD::Slot16: logic confirmed by peer review
- fn_08502 CEfstAction_FROST_STORM::Slot00: logic confirmed by peer review
- fn_08503 CEfstAction_FROST_STORM::Slot01: logic confirmed by peer review
- fn_08504 CEfstAction_FROST_STORM::Slot02: logic confirmed by peer review

Peer-reviewed-by: willerthal, ragnarok-clanker, Yommy, meitogi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-29 22:52:41 +00:00
ragnarok-clanker
898712958b Decompile 3 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/Skills/SkillInfo.h 
Batch #3108 by eAthena: 3 byte-identical, 0 confirmed by peer review.

- fn_08441 CSkillAction_BO_EXPLOSIVE_POWDER::Slot05: byte-identical
- fn_08475 CSkillAction_DK_MADNESS_CRUSHER::Slot04: byte-identical
- fn_08495 CSkillAction_DK_HACKANDSLASHER_ATK::Slot02: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-29 20:31:24 +00:00
ragnarok-clanker
5e8bddeaf2 Decompile 2 functions in Source/Contents/Skills/SkillInfo.cpp 
Batch #2708 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_08357 CEfstAction_DANCING_KNIFE::Slot00: logic confirmed by peer review
- fn_08362 CSkillAction_SHC_SHADOW_STAB::Slot16: logic confirmed by peer review

Peer-reviewed-by: willerthal, youko, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-29 19:22:18 +00:00
ragnarok-clanker
55b0c5f734 Decompile 5 functions in Source/Contents/Skills/SkillInfo.cpp 
Batch #2729 by ragnarok-clanker: 0 byte-identical, 5 confirmed by peer review.

- fn_08338 CEfstAction_UNLIMIT::Slot01: logic confirmed by peer review
- fn_08358 CEfstAction_DANCING_KNIFE::Slot01: logic confirmed by peer review
- fn_08341 CSkillAction_AG_ENERGY_CONVERSION::Slot11: logic confirmed by peer review
- fn_08365 CEfstAction_SHADOW_EXCEED::Slot00: logic confirmed by peer review
- fn_08393 CSkillAction_IQ_BLAZING_FLAME_BLAST::Slot11: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-29 18:36:03 +00:00
ragnarok-clanker
c43208818d Decompile 4 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/EffectResourceSwitcher.cpp, ... 
Batch #2534 by meitogi: 0 byte-identical, 4 confirmed by peer review.

- fn_08337 CEfstAction_UNLIMIT::Slot00: logic confirmed by peer review
- fn_08372 CSkillAction_ABC_CHASING_BREAK::Slot11: logic confirmed by peer review
- fn_08377 CSkillAction_ABC_CHASING_SHOT::Slot11: logic confirmed by peer review
- fn_03082 EffectResourceSwitcher::RetireEffects: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 17:47:45 +00:00
ragnarok-clanker
f8ea163c84 Decompile 2 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/EffectResourceSwitcher.cpp, ... 
Batch #2148 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_08329 CEfstAction_GenderChange::Slot00: logic confirmed by peer review
- fn_08330 CEfstAction_GenderChange::Slot01: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 14:38:37 +00:00
ragnarok-clanker
31422085a7 Decompile fn_03111 (CEffect::Slot22) 
Batch #2149 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_03111 CEffect::Slot22: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-29 14:34:08 +00:00
ragnarok-clanker
16cf1dce90 Decompile 29 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/EffectResourceSwitcher.cpp, ... 
Batch #2141 by ragnarok-clanker: 0 byte-identical, 29 confirmed by peer review.

- fn_08336 CSkillAction_RA_UNLIMIT::Slot11: logic confirmed by peer review
- fn_08340 CSkillAction_AG_ENERGY_CONVERSION::Slot08: logic confirmed by peer review
- fn_08342 CSkillAction_CD_DIVINUS_FLOS::Slot08: logic confirmed by peer review
- fn_08343 CSkillAction_CD_DIVINUS_FLOS::Slot11: logic confirmed by peer review
- fn_08345 CSkillAction_SHC_ENCHANTING_SHADOW::Slot08: logic confirmed by peer review
- fn_08349 CSkillAction_SHC_IMPACT_CRATER::Slot11: logic confirmed by peer review
- fn_08350 CSkillAction_SHC_IMPACT_CRATER::Slot16: logic confirmed by peer review
- fn_08352 CSkillAction_SHC_CROSS_SLASH::Slot11: logic confirmed by peer review
- fn_08353 CSkillAction_SHC_CROSS_SLASH::Slot16: logic confirmed by peer review
- fn_08355 CSkillAction_SHC_DANCING_KNIFE::Slot08: logic confirmed by peer review
- fn_08356 CSkillAction_SHC_DANCING_KNIFE::Slot16: logic confirmed by peer review
- fn_08363 CSkillAction_SHC_SHADOW_EXCEED::Slot08: logic confirmed by peer review
- fn_08373 CSkillAction_ABC_CHASING_BREAK::Slot16: logic confirmed by peer review
- fn_08376 CSkillAction_ABC_CHASING_SHOT::Slot08: logic confirmed by peer review
- fn_08378 CSkillAction_ABC_CHASING_SHOT::Slot15: logic confirmed by peer review
- fn_08379 CSkillAction_ABC_CHASING_SHOT::Slot16: logic confirmed by peer review
- fn_08381 CSkillAction_ABC_HIT_AND_SLIDING::Slot16: logic confirmed by peer review
- fn_08382 CSkillAction_ABC_ABYSS_FLAME::Slot08: logic confirmed by peer review
- fn_08383 CSkillAction_ABC_ABYSS_FLAME::Slot11: logic confirmed by peer review
- fn_08384 CSkillAction_ABC_ABYSS_FLAME::Slot16: logic confirmed by peer review
- fn_08386 CSkillAction_ABC_ABYSS_FLAME_ATK::Slot11: logic confirmed by peer review
- fn_08387 CSkillAction_ABC_ABYSS_FLAME_ATK::Slot16: logic confirmed by peer review
- fn_08388 CSkillAction_EM_PSYCHIC_STREAM::Slot08: logic confirmed by peer review
- fn_08389 CSkillAction_EM_PSYCHIC_STREAM::Slot11: logic confirmed by peer review
- fn_08390 CSkillAction_EM_PSYCHIC_STREAM::Slot16: logic confirmed by peer review
- fn_08392 CSkillAction_IQ_BLAZING_FLAME_BLAST::Slot08: logic confirmed by peer review
- fn_08394 CSkillAction_IQ_BLAZING_FLAME_BLAST::Slot16: logic confirmed by peer review
- fn_08344 CSkillAction_CD_DIVINUS_FLOS::Slot16: logic confirmed by peer review
- fn_06989 CEZ2STREffectMgr::EffectId: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-29 14:22:12 +00:00
ragnarok-clanker
cd47fe84d3 Rename CGameObject virtuals to DHXJ names across the actor hierarchy: Update->OnProcess, SendObjectMessage->SendMsg, Draw->Render, Direction->Get8Dir, SetScreenBounds->SetRenderInfo, SetScreenPosition->SetTlvert, SetAnimation->SetAction. Pure rename, codegen unchanged (314/314 functions identical with includers). 2026-10-29 14:01:33 +01:00
ragnarok-clanker
7db74ec953 Decompile 2 functions in Source/Contents/Skills/SkillInfo.cpp 
Batch #2121 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_08326 CEfstAction_ChangeSize::Slot00: logic confirmed by peer review
- fn_08364 CSkillAction_SHC_SHADOW_EXCEED::Slot11: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 12:54:53 +00:00
ragnarok-clanker
d9580bfeda Rename CWorld -> CModeMgr (g_world -> g_modeMgr, ActiveGameMode.{h,cpp} -> ModeMgr.{h,cpp}) and WorldScene -> CWorld (WorldScene.h -> World.h), as in DHXJ. Pure rename, codegen unchanged (707/707 functions identical with includers). 2026-10-29 12:27:01 +01:00
ragnarok-clanker
385c906a98 Align method names with DHXJ (GetGameMode/GetLoginMode, CRes::Lock/Unlock, InitSegment, ShiftSegment, AnimMotion, ProcessAlpha, Prim3DCircle/Casting4/Casting5/Cylinder/CylinderHalf/ParticleSpline, Get_Angle, GetRadian, matrix MakeXRotation/AppendYRotation/MakeTranslate/MakeInverse, ResetInput, IncreaseSelection, GetKeyStrokeSize, UpdateMatrix, ResetQueue, Cleanup, CGroundScope::OnProcess). Pure renames, codegen unchanged (baseline with includers). 2026-10-29 12:09:28 +01:00
ragnarok-clanker
d7862ef5c4 Decompile 9 functions in Source/Utility/Math/Vector3d.h, Source/Utility/Math/AffineMatrix.h, ... 
Batch #1843 by ragnarok-clanker: 1 byte-identical, 8 confirmed by peer review.

- fn_02024 ClientRadians: logic confirmed by peer review
- fn_17668 WorldScene::GetGameActorByAID: logic confirmed by peer review
- fn_21057 CRenderObject::GetTargetPos: logic confirmed by peer review
- fn_17667 WorldScene::GetGameActorByAidIncludeMe: logic confirmed by peer review
- fn_21290 CGameMode::NotifyItemBounds: logic confirmed by peer review
- fn_03089 CEffect::Slot25: logic confirmed by peer review
- fn_08405 CellWorldPosition: logic confirmed by peer review
- fn_19762 EffectPrimitiveSlot::EffectPrimitiveSlot: byte-identical (already on main)
- fn_19865 DrawEffectPrimitive15: logic confirmed by peer review

Peer-reviewed-by: Yommy, eAthena, ragnarok-clanker
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 22:49:51 +00:00
ragnarok-clanker
f07e52ffeb 🔥 refactor(effects): removed unused header includes 2026-10-28 23:14:51 +01:00
ragnarok-clanker
41b839b378 Merge branch 'main' of https://clank.rodecomp.online/git/clank/rodecomp 2026-10-28 23:14:46 +01:00
ragnarok-clanker
4c22f54ad0 🔥 refactor(effects): removed unused header includes 2026-10-28 23:13:11 +01:00
ragnarok-clanker
5a44997d9c Decompile 22 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/Skills/SkillInfo.h 
Batch #1769 by Yommy: 0 byte-identical, 22 confirmed by peer review.

- fn_08327 CEfstAction_ChangeSize::Slot01: logic confirmed by peer review
- fn_08328 CEfstAction_ChangeSize::Slot02: logic confirmed by peer review
- fn_08331 CEfstAction_GenderChange::Slot02: logic confirmed by peer review
- fn_08334 CEfstAction_ShowEffect::Slot02: logic confirmed by peer review
- fn_08335 CSkillAction_RA_UNLIMIT::Slot08: logic confirmed by peer review
- fn_08339 CEfstAction_UNLIMIT::Slot02: logic confirmed by peer review
- fn_08346 CEfstAction_SHADOW_WEAPON::Slot03: logic confirmed by peer review
- fn_08347 CEfstAction_SHADOW_WEAPON::Slot04: logic confirmed by peer review
- fn_08359 CEfstAction_DANCING_KNIFE::Slot02: logic confirmed by peer review
- fn_08366 CEfstAction_SHADOW_EXCEED::Slot01: logic confirmed by peer review
- fn_08367 CEfstAction_SHADOW_EXCEED::Slot02: logic confirmed by peer review
- fn_08368 CEfstAction_SHADOW_EXCEED::Slot03: logic confirmed by peer review
- fn_08369 CEfstAction_SHADOW_EXCEED::Slot04: logic confirmed by peer review
- fn_08404 CSkillActionMgr::ActionSlot01: logic confirmed by peer review
- fn_08405 CellWorldPosition: logic confirmed by peer review
- fn_08406 CSkillActionMgr::EfstSlot03: logic confirmed by peer review
- fn_08407 CSkillActionMgr::EfstSlot04: logic confirmed by peer review
- fn_08408 CSkillActionMgr::ActionSlot14: logic confirmed by peer review
- fn_08409 CSkillActionMgr::ActionSlot02: logic confirmed by peer review
- fn_08410 CSkillActionMgr::ActionSlot03: logic confirmed by peer review
- fn_08411 CSkillActionMgr::ActionSlot04: logic confirmed by peer review
- fn_08412 CSkillActionMgr::HasEfstAction: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 22:12:43 +00:00
ragnarok-clanker
be749d87c8 Decompile 3 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/Skills/SkillInfo.h 
Batch #1771 by Yommy: 3 byte-identical, 0 confirmed by peer review.

- fn_08371 CSkillAction_ABC_CHASING_BREAK::Slot07: byte-identical
- fn_08375 CSkillAction_ABC_CHASING_SHOT::Slot07: byte-identical
- fn_08385 CSkillAction_ABC_ABYSS_FLAME_ATK::Slot03: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 22:12:16 +00:00
ragnarok-clanker
eba26963c9 Add SkillId enum and name SkillInfo skill helpers 
SkillId.h: the full SKID table (1929 entries) from skillinfoz/skillid.lua. SkillInfo.cpp: every numeric skill ID replaced by its SkillId name; Sub773A00/Sub773CB0/Sub773CD0/Sub7745B0/CSkillActionMgr::Sub77B4A0 renamed IsOptionalSelfTargetSkill/HidesUseFailureMessage/IsSupportSkill/ShowsCastEffect/CSkillActionMgr::IsSupportAction from their call sites; CSkillInfo::operator= copies scalars by assignment instead of memcpy. Compiled code unchanged (all includers checked).
 2026-10-28 22:19:15 +01:00
ragnarok-clanker
21ea249664 Decompile 2 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/Skills/SkillInfo.h 
Batch #1707 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_08322 Sub773CD0: logic confirmed by peer review
- fn_08413 CSkillActionMgr::Sub77B4A0: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 20:39:14 +00:00
ragnarok-clanker
4f0d60a4a7 Decompile 2 functions in Source/Contents/Skills/SkillInfo.cpp 
Batch #1595 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_08320 Sub773A00: logic confirmed by peer review
- fn_08324 Sub7745B0: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker
Reviewed-by: ragnarok-clanker
 2026-10-28 19:42:33 +00:00
ragnarok-clanker
c8d7550973 Decompile fn_08321 (Sub773CB0) 
Batch #1342 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_08321 Sub773CB0: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
 2026-10-28 11:00:58 +00:00
ragnarok-clanker
d766d07a84 Decompile fn_08319 (Sub7739F0) 
Batch #1224 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_08319 Sub7739F0: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-27 21:41:40 +00:00