clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity
87 commits 1 branch 0 tags 11 MiB
Commit graph

87 commits

This branch
This branch
All branches
Author SHA1 Message Date
ragnarok-clanker
d33f0e43de Document multi-agent workspace and add Linux/Windows slot, check and symbol helpers; fix td disasm and runner notes 2026-10-27 00:07:48 +01:00
ragnarok-clanker
2c7250f0c8 Decompile fn_00161 (PriceCommission) 
Batch #898 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_00161 PriceCommission: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/UI/PriceCommission.cpp
 2026-10-26 22:56:16 +00:00
ragnarok-clanker
4def72328f Decompile 2 functions in Source/Contents/Hotkeys/HotkeyInfo.cpp, Source/Contents/Hotkeys/HotkeyInfo.h 
Batch #895 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_10278 SkillTooltipPercent: logic confirmed by peer review
- fn_10279 SkillTooltipFlat: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-26 22:56:15 +00:00
ragnarok-clanker
ff36f34044 Decompile 5 functions in Source/Contents/TipBoxTitles.cpp, Source/Contents/TipBoxTitles.h 
Batch #894 by ragnarok-clanker: 0 byte-identical, 5 confirmed by peer review.

- fn_09122 CTipBoxMgr::AddParagraph: logic confirmed by peer review
- fn_09123 CTipBoxMgr::Create: logic confirmed by peer review
- fn_09124 CTipBoxMgr::Destroy: logic confirmed by peer review
- fn_09125 CTipBoxMgr::SelectRandomTip: logic confirmed by peer review
- fn_09126 CTipBoxMgr::GetTip: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-26 22:56:14 +00:00
ragnarok-clanker
e0997ca0e5 Decompile 3 functions in Source/Contents/ActorNameCard.cpp, Source/Contents/ActorNameCard.h 
Batch #890 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_03484 CActorNameCard::CActorNameCard: logic confirmed by peer review
- fn_03485 CActorNameCard::~CActorNameCard: logic confirmed by peer review
- fn_03493 CActorNameCardHolder::~CActorNameCardHolder: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-26 22:55:47 +00:00
ragnarok-clanker
fd1dc5f008 Decompile fn_18245 (RemoveDirectoryTree) 
Batch #870 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_18245 RemoveDirectoryTree: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/File/DirectoryRemoval.cpp
 2026-10-26 22:55:40 +00:00
ragnarok-clanker
bb091ae751 Decompile 4 functions in Source/File/FileCreation.cpp, Source/File/FileCreation.h, ... 
Batch #869 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_18255 CreateDirectoryPath: logic confirmed by peer review
- fn_18256 CreateUniqueFileName: logic confirmed by peer review
- fn_18252 FormatOwnedString: logic confirmed by peer review
- fn_03451 StringFormat: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/File/FileCreation.cpp
 2026-10-26 22:55:38 +00:00
ragnarok-clanker
7b9898cab9 Decompile 3 functions in Source/Utility/SHA3.cpp, Source/Utility/SHA3.h 
Batch #866 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_04423 SHA3::Add: logic confirmed by peer review
- fn_04424 SHA3::GetHash: logic confirmed by peer review
- fn_04425 SHA3::ProcessBlock: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/SHA3.cpp
 2026-10-26 22:55:21 +00:00
ragnarok-clanker
d985a63065 Decompile 4 functions in Source/Utility/RegistryKey.cpp, Source/Utility/RegistryKey.h 
Batch #864 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_18150 RegistryKey::Create: logic confirmed by peer review
- fn_18151 RegistryKey::Open: logic confirmed by peer review
- fn_18152 RegistryKey::Query: logic confirmed by peer review
- fn_18153 RegistryKey::Set: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/RegistryKey.cpp
 2026-10-26 22:54:37 +00:00
ragnarok-clanker
bcb352fd91 Decompile fn_18121 (myGPack::DecryptPakData) 
Batch #862 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_18121 myGPack::DecryptPakData: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Archive/PakCrypto.cpp
 2026-10-26 22:54:09 +00:00
ragnarok-clanker
daa7e4690a Confirm fn_17773 (LanguageCodePage) 
Batch #861 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17773 LanguageCodePage: logic confirmed by peer review (already on main)

Reviewed-by: ragnarok-clanker
 2026-10-26 22:54:07 +00:00
ragnarok-clanker
315559e0b8 Decompile 14 functions in Source/Utility/MD5.cpp, Source/Utility/MD5.h 
Batch #859 by ragnarok-clanker: 0 byte-identical, 14 confirmed by peer review.

- fn_00122 MD5::~MD5: logic confirmed by peer review
- fn_00123 MD5::Decode: logic confirmed by peer review
- fn_00124 MD5::Initialize: logic confirmed by peer review
- fn_00125 MD5::Transform: logic confirmed by peer review
- fn_00126 MD5::Update: logic confirmed by peer review
- fn_00127 MD5::Finalize: logic confirmed by peer review
- fn_00128 MD5::DigestBuffer: logic confirmed by peer review
- fn_00129 MD5::HashBuffer: logic confirmed by peer review
- fn_00130 MD5::HashString: logic confirmed by peer review
- fn_00131 MD5::HashString: logic confirmed by peer review
- fn_00132 MD5::HashFile: logic confirmed by peer review
- fn_00133 MD5::HashStringLower: logic confirmed by peer review
- fn_00134 MD5::HashStringLower: logic confirmed by peer review
- fn_00135 MD5::HashFile: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/MD5.cpp
 2026-10-26 22:53:51 +00:00
ragnarok-clanker
3a5e3ddd15 Decompile 6 functions in Source/Utility/FileSignatureVerifier.cpp, Source/Utility/FileSignatureVerifier.h 
Batch #858 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_00136 FileSignatureVerifier::FileSignatureVerifier: logic confirmed by peer review
- fn_45444 FileSignatureVerifier::~FileSignatureVerifier: logic confirmed by peer review
- fn_00138 FileSignatureVerifier::VerifyBuffer: logic confirmed by peer review
- fn_00139 FileSignatureVerifier::VerifyFile: logic confirmed by peer review
- fn_00140 FileSignatureVerifier::VerifyBuffer: logic confirmed by peer review
- fn_00141 FileSignatureVerifier::VerifyFile: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/FileSignatureVerifier.cpp
 2026-10-26 22:53:49 +00:00
ragnarok-clanker
94eb5ab852 Decompile fn_07589 (NFileLog::Initialize) 
Batch #857 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_07589 NFileLog::Initialize: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/NFileLog.cpp
 2026-10-26 22:53:19 +00:00
ragnarok-clanker
b7c7ea1461 Decompile 3 functions in Source/Network/TextEncoding.cpp, Source/Network/TextEncoding.h 
Batch #852 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_18257 LowercaseText: logic confirmed by peer review
- fn_18258 DecodeText: logic confirmed by peer review
- fn_18265 EncodeText: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-26 22:53:18 +00:00
ragnarok-clanker
e99b978f19 Decompile 3 functions in Source/Utility/NIPAddr.cpp, Source/Utility/NIPAddr.h 
Batch #853 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_07599 NIPAddr::NIPAddr: logic confirmed by peer review
- fn_07601 NIPAddr::~NIPAddr: logic confirmed by peer review
- fn_07603 NIPAddr::IsPrivateAddress: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/NIPAddr.cpp
 2026-10-26 22:53:01 +00:00
ragnarok-clanker
81e3560708 Decompile 6 functions in Source/Utility/AES.cpp, Source/Utility/AES.h 
Batch #851 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_04417 AES::~AES: logic confirmed by peer review
- fn_04418 AES::Decrypt: logic confirmed by peer review
- fn_04419 AES::Initialize: logic confirmed by peer review
- fn_04420 AES::Initialize: logic confirmed by peer review
- fn_04421 AES::SetIV: logic confirmed by peer review
- fn_04422 AES::SetMode: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/AES.cpp
 2026-10-26 22:52:29 +00:00
ragnarok-clanker
8268da4030 Decompile 4 functions in Source/Utility/Math/AffineMatrix.cpp, Source/Utility/Math/AffineMatrix.h 
Batch #848 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_02026 AffineMatrix::IsIdentity: logic confirmed by peer review
- fn_02028 AffineMatrix::SetScale: logic confirmed by peer review
- fn_02031 AffineMatrix::SetAxisRotation: logic confirmed by peer review
- fn_02032 AffineMatrix::SetTranslation: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-26 22:52:27 +00:00
ragnarok-clanker
0e34f07e13 Decompile 10 functions in Source/Utility/CRC32.cpp, Source/Utility/CRC32.h 
Batch #850 by ragnarok-clanker: 0 byte-identical, 10 confirmed by peer review.

- fn_00142 CRC32::CRC32: logic confirmed by peer review
- fn_00143 CRC32::~CRC32: logic confirmed by peer review
- fn_00144 CRC32::Update: logic confirmed by peer review
- fn_00145 CRC32::UpdateFile: logic confirmed by peer review
- fn_00146 CRC32::Calculate: logic confirmed by peer review
- fn_00147 CRC32::Calculate: logic confirmed by peer review
- fn_00148 CRC32::CalculateLowercase: logic confirmed by peer review
- fn_00149 CRC32::CalculateLowercase: logic confirmed by peer review
- fn_00150 CRC32::Calculate: logic confirmed by peer review
- fn_00151 CRC32::CalculateFile: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/CRC32.cpp
 2026-10-26 22:52:17 +00:00
ragnarok-clanker
a74163aa29 Decompile fn_18259 (FormatGuid) 
Batch #849 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_18259 FormatGuid: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-26 22:52:03 +00:00
ragnarok-clanker
fa6f84f567 Decompile 4 functions in Source/UI/MiniPartyGrid.cpp, Source/UI/MiniPartyGrid.h 
Batch #847 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_07659 MiniPartyGrid::GetCellPosition: logic confirmed by peer review
- fn_07660 MiniPartyGrid::GetWindowPosition: logic confirmed by peer review
- fn_07661 MiniPartyGrid::FindCell: logic confirmed by peer review
- fn_07662 MiniPartyGrid::BuildAvailableCells: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/UI/MiniPartyGrid.cpp
 2026-10-26 22:51:41 +00:00
ragnarok-clanker
34640f204c Decompile 4 functions in Source/Utility/ProcessSecurity.cpp, Source/Utility/ProcessSecurity.h 
Batch #845 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_18122 RemoveProtectionTools: logic confirmed by peer review
- fn_18123 SetDebugPrivilege: logic confirmed by peer review
- fn_18124 LoadLibraryFunctions: logic confirmed by peer review
- fn_18125 IsLegacyWindows: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/ProcessSecurity.cpp
 2026-10-26 22:51:40 +00:00
ragnarok-clanker
14197ed459 Decompile 7 functions in Source/Resource/XmlNode.cpp, Source/Resource/XmlNode.h 
Batch #844 by ragnarok-clanker: 0 byte-identical, 7 confirmed by peer review.

- fn_18291 XmlNode::XmlNode: logic confirmed by peer review
- fn_18292 XmlNode::`scalar deleting destructor': logic confirmed by peer review
- fn_18293 XmlNode::AppendSibling: logic confirmed by peer review
- fn_18294 XmlDocument::Reset: logic confirmed by peer review
- fn_18295 XmlNode::Clear: logic confirmed by peer review
- fn_18296 XmlNode::FindChild: logic confirmed by peer review
- fn_18297 XmlNode::FindSibling: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Resource/XmlNode.cpp
 2026-10-26 22:51:22 +00:00
ragnarok-clanker
2bd93fdbc7 Decompile fn_07868 (DecodeGifLzw) 
Batch #843 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_07868 DecodeGifLzw: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Resource/GifLzw.cpp
 2026-10-26 22:51:20 +00:00
ragnarok-clanker
0b7a9c54d5 Decompile 2 functions in Source/File/FileEnumeration.cpp, Source/File/FileEnumeration.h 
Batch #868 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_18246 EnumerateFileNames: logic confirmed by peer review
- fn_18247 EnumerateFileNames: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/File/FileEnumeration.cpp
 2026-10-26 22:50:30 +00:00
ragnarok-clanker
bf6a44c117 Group Utility units into subsystem folders and require OFFSET provenance 
Move Lexicon*, Text (TextTokens, TextEscapes, Base64), Math/RadialGrid, Hash (MD5, XxHash32) and Cipher (Rijndael, XorBytes) into Source/Utility subfolders; update includes, guards, compile.json and CMakeLists.txt. Backfill // OFFSET: above every standalone // FUNCTION: block (89 IDs, addresses from the symbol database) and make it mandatory in CODING_RULES.md and AGENTS.md. Remove the MatchLexicon cast chain.
 2026-10-26 23:41:07 +01:00
ragnarok-clanker
caea0f2937 Decompile fn_01842 (ApplyPixelFilter) 
Batch #911 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_01842 ApplyPixelFilter: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-26 22:07:53 +00:00
ragnarok-clanker
31bd9d1952 Decompile 2 functions in Source/Contents/Hotkeys/UserHotkeyScript.cpp, Source/Contents/Hotkeys/UserHotkeyScript.h 
Batch #910 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_04064 ChangeUserHotkey: logic confirmed by peer review
- fn_03473 LoadUserHotkeyTab: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-26 22:07:49 +00:00
ragnarok-clanker
f2eed45548 Decompile 4 functions in Source/Archive/PakCipher.cpp, Source/Archive/PakCipher.h 
Batch #909 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_18102 myGPack::EncodeBlock: logic confirmed by peer review
- fn_18103 myGPack::FinalPermutation: logic confirmed by peer review
- fn_18104 myGPack::InitialPermutation: logic confirmed by peer review
- fn_18131 myGPack::DerivePakKey: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-26 22:07:43 +00:00
ragnarok-clanker
e5031b68a9 Decompile fn_17631 (MatchLexicon) 
Batch #842 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17631 MatchLexicon: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/LexiconMatcher.cpp
 2026-10-26 22:06:51 +00:00
ragnarok-clanker
3897c27241 Decompile 4 functions in Source/Contents/ActorGeometry.cpp, Source/Contents/Actors/RenderObject.h, ... 
Batch #837 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_21007 CRenderObject::Heading: logic confirmed by peer review
- fn_21008 CRenderObject::Face: logic confirmed by peer review
- fn_21009 CRenderObject::HorizontalDistance: logic confirmed by peer review
- fn_21010 CRenderObject::Distance: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/ActorGeometry.cpp
 2026-10-26 21:51:37 +00:00
ragnarok-clanker
9e8afe0df6 Decompile 2 functions in Source/Utility/LexiconSerializer.cpp, Source/Utility/LexiconSerializer.h 
Batch #841 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_17630 LexiconSerializer::Destroy: logic confirmed by peer review
- fn_17633 LexiconSerializer::Serialize: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/LexiconSerializer.cpp
 2026-10-26 21:51:25 +00:00
ragnarok-clanker
c029673ec9 Decompile 3 functions in Source/Utility/TextTokens.cpp, Source/Utility/TextTokens.h 
Batch #840 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_01963 IsPipeColorToken: logic confirmed by peer review
- fn_01964 IsHexColorToken: logic confirmed by peer review
- fn_13883 StripColorTokens: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/TextTokens.cpp
 2026-10-26 21:50:40 +00:00
ragnarok-clanker
b2d178ac32 Decompile fn_17876 (MovementRouteInterpolation::Sample) 
Batch #838 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17876 MovementRouteInterpolation::Sample: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-26 21:50:25 +00:00
ragnarok-clanker
b3b7fd0281 Decompile 2 functions in Source/Render/ViewportProjection.cpp, Source/Render/Renderer.h 
Batch #836 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_02104 CRenderer::ProjectViewport: logic confirmed by peer review
- fn_02105 CRenderer::ProjectViewportCentered: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Render/ViewportProjection.cpp
 2026-10-26 21:50:07 +00:00
ragnarok-clanker
02d760984c Decompile fn_18244 (DecodeTextEscapes) 
Batch #835 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_18244 DecodeTextEscapes: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/TextEscapes.cpp
 2026-10-26 21:49:45 +00:00
ragnarok-clanker
f66874c19f Decompile fn_17634 (LexiconBoundary::Matches) 
Batch #834 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17634 LexiconBoundary::Matches: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/LexiconBoundary.cpp
 2026-10-26 21:49:26 +00:00
ragnarok-clanker
e2351a9e3a Decompile fn_01845 (CDCBitmap::Create) 
Batch #833 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_01845 CDCBitmap::Create: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-26 21:49:25 +00:00
ragnarok-clanker
5a761209d2 Decompile 2 functions in Source/Utility/XxHash32.cpp, Source/Utility/XxHash32.h 
Batch #832 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_00162 XxHash32: logic confirmed by peer review
- fn_00163 FinalizeXxHash32: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/XxHash32.cpp
 2026-10-26 21:49:13 +00:00
ragnarok-clanker
740b67081d Decompile 10 functions in Source/Utility/Timestamp.cpp, Source/Utility/Timestamp.h 
Batch #830 by ragnarok-clanker: 0 byte-identical, 10 confirmed by peer review.

- fn_18085 Timestamp::ToSqlTimestamp: logic confirmed by peer review
- fn_18086 Timestamp::IsBefore: logic confirmed by peer review
- fn_18087 Timestamp::IsBeforeNow: logic confirmed by peer review
- fn_18088 Timestamp::Day: logic confirmed by peer review
- fn_18089 Timestamp::Hour: logic confirmed by peer review
- fn_18090 Timestamp::Minute: logic confirmed by peer review
- fn_18091 Timestamp::Month: logic confirmed by peer review
- fn_18092 Timestamp::Second: logic confirmed by peer review
- fn_18093 Timestamp::Year: logic confirmed by peer review
- fn_18094 Timestamp::SetDate: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-26 21:48:54 +00:00
ragnarok-clanker
820df68d42 Decompile fn_18251 (GenerateRadialGrid) 
Batch #829 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_18251 GenerateRadialGrid: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/RadialGrid.cpp
 2026-10-26 21:48:52 +00:00
ragnarok-clanker
5bd1a554b0 Decompile 3 functions in Source/Contents/Items/ItemDescription.cpp, Source/Contents/Items/ItemDescription.h 
Batch #930 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_06546 EnsureItemCardName: logic confirmed by peer review
- fn_06547 EnsureItemDescriptionLines: logic confirmed by peer review
- fn_06579 FindItemDescription: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-26 21:46:27 +00:00
ragnarok-clanker
7541fbec29 Decompile 6 functions in Source/Contents/GuildMgr.cpp, Source/Contents/GuildMgr.h, ... 
Batch #889 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_05147 CGuild::CGuild: logic confirmed by peer review
- fn_05148 CGuild::~CGuild: logic confirmed by peer review
- fn_05172 CGuildMgr::Create: logic confirmed by peer review
- fn_05173 CGuildMgr::Destroy: logic confirmed by peer review
- fn_05175 CGuildMgr::GetEmblemVersion: logic confirmed by peer review
- fn_05181 CGuildMgr::SetEmblemVersion: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/GuildMgr.cpp, Source/Contents/GuildEmblemState.cpp
 2026-10-26 21:46:02 +00:00
ragnarok-clanker
6f8a35191a Decompile 2 functions in Source/Contents/Jobs/JobNames.cpp 
Batch #929 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_24165 JobNames::BaseJob: logic confirmed by peer review
- fn_23396 JobNames::Lookup: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-26 21:45:07 +00:00
ragnarok-clanker
1122aa7c98 Decompile 7 functions in Source/Contents/Jobs/JobId.h, Source/Contents/Jobs/JobInheritance.cpp, ... 
Batch #921 by ragnarok-clanker: 0 byte-identical, 7 confirmed by peer review.

- fn_23461 GetRealWeaponId: logic confirmed by peer review
- fn_23585 ?IsTreeGroupTwo@?A0x66373c89@@YA_NH@Z: logic confirmed by peer review
- fn_23586 ?IsTreeGroupThree@?A0x66373c89@@YA_NH@Z: logic confirmed by peer review
- fn_23587 IsPlayerJob: logic confirmed by peer review
- fn_23907 JobInheritance::InitializeSkillTree: logic confirmed by peer review
- fn_23495 JobNames::Initialize: logic confirmed by peer review
- fn_23444 AttackMotionLength: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-26 21:33:33 +00:00
ragnarok-clanker
ab4f30f7b0 Maintenance: Remove unused cstdint and string includes from JobNames.h; types and declarations unchanged. Checked exact header payloa 
Batch #912 by ragnarok-clanker: no function's compiled code changes; checked with 4 compiled unit(s), including every includer of Source/Contents/Jobs/JobNames.h.
 2026-10-26 20:58:39 +00:00
ragnarok-clanker
21f8c520e3 Document implicit calling conventions except at fixed ABI boundaries 2026-10-26 20:40:28 +00:00
ragnarok-clanker
e792ccc6ea Maintenance: Preserve original non-null empty C-string initializer: slot 0x01348F80 contains 0x010D4EE8 and its target starts with NU 
Batch #908 by ragnarok-clanker: no function's compiled code changes; checked with 1 compiled unit(s).
 2026-10-26 19:23:28 +00:00
ragnarok-clanker
935383f431 Document and enable global storage ownership checks 2026-10-26 19:15:28 +00:00
ragnarok-clanker
f575258340 Maintenance: Define every global once in its owner unit; session members replace member globals 
Batch #906 by ragnarok-clanker: no function's compiled code changes; checked with 9 compiled unit(s), including every includer of Source/Client/Session.h, Source/Client/Registry.h, Source/Client/Application/LaunchInfo.h, Source/Client/Application/Launcher.h, Source/Client/Mode/ActiveGameMode.h, Source/Render/DeviceSelection.h.
Adds to the build: Source/Client/Session.cpp, Source/Client/Registry.cpp, Source/Client/Application/LaunchInfo.cpp, Source/Render/DeviceSelection.cpp
 2026-10-26 18:34:25 +00:00