Commit graph

292 commits

Author SHA1 Message Date
ragnarok-clanker
dcecaa8a09 Decompile 5 functions in Source/UI/WindowTitlebar.cpp, Source/UI/WindowBackground.cpp, ...
Batch #1396 by Yommy: 0 byte-identical, 5 confirmed by peer review.

- fn_12098 UIWindow::DrawTitleBar: logic confirmed by peer review
- fn_12099 UIWindow::DrawTitleBarAt: logic confirmed by peer review
- fn_12085 UIWindow::DrawPanelBackground: logic confirmed by peer review
- fn_12086 UIWindow::DrawPanelBackgroundAt: logic confirmed by peer review
- fn_12088 UIWindow::DrawButtonBar: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/UI/WindowTitlebar.cpp, Source/UI/WindowBackground.cpp
2026-10-28 12:16:43 +00:00
ragnarok-clanker
2c4164fc4d Decompile 2 functions in Source/Contents/NavigationSource.cpp, Source/Contents/NavigationManager.h
Batch #1394 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_19588 NavigationManager::GetCurrentTarget: logic confirmed by peer review
- fn_19590 NavigationManager::GetSavedTarget: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 12:16:00 +00:00
ragnarok-clanker
a16b447574 Decompile 2 functions in Source/Contents/Actors/RenderObject.cpp, Source/Contents/Actors/GameActor.h
Batch #1391 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_21141 CGameActor::SetUnknown0318: logic confirmed by peer review
- fn_21145 CGameActor::SetUnknown0330: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 12:15:16 +00:00
ragnarok-clanker
9d3e6d1668 Decompile 2 functions in Source/Contents/NavigationSource.cpp, Source/Contents/NavigationManager.h
Batch #1395 by Yommy: 2 byte-identical, 0 confirmed by peer review.

- fn_19597 NavigationManager::GetCurrentTargetType: byte-identical
- fn_19635 NavigationManager::SaveCurrentTarget: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/NavigationSource.cpp
2026-10-28 12:13:49 +00:00
ragnarok-clanker
c05b411b4d Decompile 6 functions in Source/Contents/Actors/RenderObject.cpp, Source/Contents/Actors/GameActor.h
Batch #1393 by ragnarok-clanker: 6 byte-identical, 0 confirmed by peer review.

- fn_21136 CGameActor::Slot30: byte-identical
- fn_21147 CGameActor::Slot25: byte-identical
- fn_21148 CGameActor::Slot18: byte-identical
- fn_21149 CGameActor::Slot22: byte-identical
- fn_21150 CGameActor::Slot21: byte-identical
- fn_21152 CGameActor::Slot23: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 12:13:36 +00:00
ragnarok-clanker
b684478589 Decompile fn_12631 (UINewChatWnd::Move)
Batch #1390 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_12631 UINewChatWnd::Move: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 12:12:31 +00:00
ragnarok-clanker
545678314f Decompile fn_02254 (LightmappedBuffer::Clear)
Batch #1389 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_02254 LightmappedBuffer::Clear: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 12:11:17 +00:00
ragnarok-clanker
2830117a5d Decompile fn_04259 (CreatePlayerNameDictionary)
Batch #1388 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_04259 CreatePlayerNameDictionary: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 12:11:17 +00:00
ragnarok-clanker
dd7b67cbe3 Decompile 2 functions in Source/UI/Edit/UIEditCtrl.cpp, Source/UI/Edit/UIEditCtrl.h, ...
Batch #1333 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_10977 UIEditCtrl::MoveCandidateWindow: logic confirmed by peer review
- fn_10978 UIEditCtrl::MoveReadingWindow: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 12:08:44 +00:00
ragnarok-clanker
b55f4ca4c5 Decompile 3 functions in Source/UI/Buttons/UITextButton.cpp, Source/UI/Lists/UITreeView.h, ...
Batch #1386 by Yommy: 1 byte-identical, 2 confirmed by peer review.

- fn_11446 UITreeView::Slot31: logic confirmed by peer review
- fn_11455 UIItemTagButton::Slot28: logic confirmed by peer review
- fn_11459 UIStaticItem_Illust::Slot28: byte-identical

Reviewed-by: ragnarok-clanker
2026-10-28 12:08:06 +00:00
ragnarok-clanker
cdc3c895f1 Decompile 2 functions in Source/Resource/ResourceMgr.cpp, Source/Resource/ResourceMgr.h
Batch #1385 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_18209 ResourceMgr::Instance: logic confirmed by peer review
- fn_18189 ResourceMgr::UnloadAll: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 12:08:03 +00:00
ragnarok-clanker
9176a8bc81 Decompile fn_11250 (UIScrollBar::Configure)
Batch #1334 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_11250 UIScrollBar::Configure: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 12:07:33 +00:00
ragnarok-clanker
cb0da9d674 Decompile fn_13690 (GuildWndInfo::Reset)
Batch #1313 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_13690 GuildWndInfo::Reset: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 12:07:13 +00:00
ragnarok-clanker
ee280b667b Decompile fn_23401 (CSession::MercSkillLevel)
Batch #1324 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_23401 CSession::MercSkillLevel: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 12:06:46 +00:00
ragnarok-clanker
e6d114bd15 Decompile fn_18338 (LuaScript::Load)
Batch #1322 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_18338 LuaScript::Load: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 12:06:34 +00:00
ragnarok-clanker
294159cd14 Decompile 2 functions in Source/UI/Window/WindowBorder.cpp, Source/UI/Window/WindowBorder.h
Batch #1383 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_16943 DrawFilledRoundedBorder: logic confirmed by peer review
- fn_16946 FillTriangle: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 12:06:20 +00:00
ragnarok-clanker
125a8d26f9 Decompile 5 functions in Source/Contents/Actors/RenderObject.cpp, Source/Contents/Actors/RenderObject.h, ...
Batch #1380 by Yommy: 0 byte-identical, 5 confirmed by peer review.

- fn_21117 CGameActor::SetAnimation: logic confirmed by peer review
- fn_21121 CRenderObject::HoverHeight: logic confirmed by peer review
- fn_21123 CRenderObject::ScaleByPulse: logic confirmed by peer review
- fn_21124 CRenderObject::ApplySwing: logic confirmed by peer review
- fn_21138 CRenderObject::SetInstantValue: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 12:06:17 +00:00
ragnarok-clanker
648ae44d9d Decompile 2 functions in Source/Contents/AdventureGuideMgr.cpp, Source/Contents/AdventureGuideMgr.h, ...
Batch #1377 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_05237 CAdventureGuideMgr::GetEpisodeList: logic confirmed by peer review
- fn_05238 CAdventureGuideMgr::GetContentsList: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 12:06:16 +00:00
ragnarok-clanker
1ad3634553 Decompile 2 functions in Source/UI/UILapineScrollBar.cpp, Source/UI/UIIngredientInfoWnd.h
Batch #1375 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_04149 UIIngredientInfoWnd::Slot10: logic confirmed by peer review
- fn_04152 UIIngredientInfoWnd::Move: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/UI/UILapineScrollBar.cpp
2026-10-28 12:05:50 +00:00
ragnarok-clanker
79c8823d57 Decompile fn_06602 (IsNumericText)
Batch #1373 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_06602 IsNumericText: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 12:05:19 +00:00
ragnarok-clanker
bb3895d424 Decompile 4 functions in Source/UI/Window/UIMessageBox.cpp, Source/UI/Window/UINoticeWnd.h, ...
Batch #1379 by Yommy: 4 byte-identical, 0 confirmed by peer review.

- fn_11757 UINoticeWnd::Slot18: byte-identical
- fn_11758 UISelectReplayDataWnd::Slot18: byte-identical
- fn_11759 UISelectServerWnd::Slot18: byte-identical
- fn_11765 UILoginWnd::Paint: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 11:58:47 +00:00
ragnarok-clanker
3cdd0a82d7 Decompile 2 functions in Source/UI/Window/UIFrameWnd.cpp, Source/UI/Lists/UIReplayListBox.h, ...
Batch #1370 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_11780 UIReplayListBox::Slot25: logic confirmed by peer review
- fn_11735 UIFrameWnd::Move: logic confirmed by peer review (already on main)

Reviewed-by: ragnarok-clanker
2026-10-28 11:45:27 +00:00
ragnarok-clanker
e541c278b4 Decompile fn_17786 (TextInputBuffer::SetFlag8C)
Batch #1372 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17786 TextInputBuffer::SetFlag8C: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 11:44:54 +00:00
ragnarok-clanker
c689e0ab5c Decompile fn_11785 (UINoticeWnd::Slot28)
Batch #1371 by Yommy: 1 byte-identical, 0 confirmed by peer review.

- fn_11785 UINoticeWnd::Slot28: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 11:44:41 +00:00
ragnarok-clanker
1c377a8040 Decompile fn_03597 (UINavigationroadiconWnd::Slot31)
Batch #1364 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_03597 UINavigationroadiconWnd::Slot31: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 11:44:39 +00:00
ragnarok-clanker
dc2307a00e Decompile 3 functions in Source/Contents/Items/ItemInfo.cpp, Source/Contents/Items/ItemInfo.h
Batch #1368 by Yommy: 0 byte-identical, 3 confirmed by peer review.

- fn_06601 ItemInfo::IsForgeMaterial: logic confirmed by peer review
- fn_06604 ItemInfo::IsElementalStone: logic confirmed by peer review
- fn_06605 ItemInfo::IsAboveItemId600: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 11:44:10 +00:00
ragnarok-clanker
2bd9f525a3 Decompile 2 functions in Source/UI/Window/UIWindow.cpp, Source/UI/Navigation/UINavigationV4Wnd.h
Batch #1369 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_03555 UINavigationV4Wnd::ClearRouteTexts: logic confirmed by peer review
- fn_03604 UINavigationV4Wnd::Slot19: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 11:44:06 +00:00
ragnarok-clanker
b37a833f5b Decompile fn_24226 (RequestBasicInfoRefresh)
Batch #1359 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_24226 RequestBasicInfoRefresh: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 11:43:57 +00:00
ragnarok-clanker
96acca76c3 Decompile fn_02010 (ModelFace::~ModelFace)
Batch #1356 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_02010 ModelFace::~ModelFace: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 11:42:53 +00:00
ragnarok-clanker
64bd0730d5 Decompile fn_24225 (CSession::CollectCardItems)
Batch #1366 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_24225 CSession::CollectCardItems: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/ClientState.cpp
2026-10-28 11:42:30 +00:00
ragnarok-clanker
713acc513f Decompile fn_02450 (CreateTexture)
Batch #1365 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_02450 CreateTexture: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 11:42:11 +00:00
ragnarok-clanker
69232871b3 Decompile fn_20960 (CreateCooldownOwner)
Batch #1355 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_20960 CreateCooldownOwner: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 11:08:09 +00:00
ragnarok-clanker
83391f8a3a Decompile fn_01853 (CDCBitmap::SetAlpha)
Batch #1307 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_01853 CDCBitmap::SetAlpha: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 11:07:52 +00:00
ragnarok-clanker
9f6fb7853f Decompile fn_02021 (??0AngleTables@?A0x87babb67@@QAE@XZ)
Batch #1298 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_02021 ??0AngleTables@?A0x87babb67@@QAE@XZ: logic confirmed by peer review (annotation added to existing code)

Reviewed-by: ragnarok-clanker
2026-10-28 11:06:58 +00:00
ragnarok-clanker
0880609085 Decompile fn_17827 (ShowErrorDialog)
Batch #1352 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17827 ShowErrorDialog: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 11:06:57 +00:00
ragnarok-clanker
ae4b24169a Decompile fn_18140 (CMemMapPakFile::CMemMapPakFile)
Batch #1351 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_18140 CMemMapPakFile::CMemMapPakFile: logic confirmed by peer review (annotation added to existing code)

Reviewed-by: ragnarok-clanker
2026-10-28 11:05:47 +00:00
ragnarok-clanker
611a78a1e9 Decompile 2 functions in Source/Utility/GGHash.cpp, Source/Utility/GGHash.h
Batch #1350 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_00116 CGGHash::VerifyBuffer: logic confirmed by peer review
- fn_00117 CGGHash::VerifyFile: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 11:05:16 +00:00
ragnarok-clanker
8be53994ff Decompile 2 functions in Source/Utility/GGHash.cpp, Source/Utility/GGHash.h
Batch #1349 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_00119 CGGHash::VerifyBuffer: logic confirmed by peer review
- fn_00120 CGGHash::VerifyFile: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 11:05:05 +00:00
ragnarok-clanker
d0e1791277 Decompile fn_00115 (CGGHash::Load)
Batch #1348 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_00115 CGGHash::Load: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 11:04:53 +00:00
ragnarok-clanker
796a2265df Decompile 2 functions in Source/Contents/PlayerNameDictionary.cpp, Source/Contents/PlayerNameDictionary.h
Batch #1347 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_04260 DestroyPlayerNameDictionary: logic confirmed by peer review
- fn_04261 LookupPlayerName: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 11:04:17 +00:00
ragnarok-clanker
10ddfd73d0 Decompile fn_03498 (CActorNameCardHolder::FindId)
Batch #1276 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_03498 CActorNameCardHolder::FindId: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 11:04:03 +00:00
ragnarok-clanker
0859a01a27 Decompile fn_03503 (CActorNameCardHolder::Contains)
Batch #1346 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_03503 CActorNameCardHolder::Contains: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 11:03:39 +00:00
ragnarok-clanker
5807cc52c4 Decompile fn_23282 (ClientItemLists::AddItem1710)
Batch #1345 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_23282 ClientItemLists::AddItem1710: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 11:03:07 +00:00
ragnarok-clanker
f8fb45fb1e Decompile fn_02097 (CRenderer::ScaleDistance)
Batch #1344 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_02097 CRenderer::ScaleDistance: logic confirmed by peer review (annotation added to existing code)

Reviewed-by: ragnarok-clanker
2026-10-28 11:01:55 +00:00
ragnarok-clanker
241c913563 Decompile fn_17790 (TextInputBuffer::RetreatCursor)
Batch #1343 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17790 TextInputBuffer::RetreatCursor: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-28 11:01:42 +00:00
ragnarok-clanker
c8d7550973 Decompile fn_08321 (Sub773CB0)
Batch #1342 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_08321 Sub773CB0: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-28 11:00:58 +00:00
ragnarok-clanker
8b355f785a Decompile fn_09130 (CTipBoxMgr::IsLastTip)
Batch #1341 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_09130 CTipBoxMgr::IsLastTip: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 11:00:15 +00:00
ragnarok-clanker
3b1bd4bb08 Decompile 3 functions in Source/Render/Primitives/RenderPrimitive.cpp, Source/Render/Primitives/RenderPrimitive.h
Batch #1339 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_02255 RenderPrimitive::operator=: logic confirmed by peer review
- fn_02256 RenderCommand::AllocateTriangles: logic confirmed by peer review
- fn_02264 RenderCommand::SetPosition: logic confirmed by peer review

Peer-reviewed-by: tester
Reviewed-by: ragnarok-clanker
2026-10-28 10:55:47 +00:00
ragnarok-clanker
22d7370193 Decompile 4 functions in Source/Contents/Items/ItemInfo.cpp, Source/Contents/Items/ItemInfo.h, ...
Batch #1336 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_02473 CTexture::Touch: logic confirmed by peer review
- fn_06603 ItemInfo::IsApprenticeItem: logic confirmed by peer review
- fn_24179 CSession::IsReducedSkill: logic confirmed by peer review
- fn_23614 CSession::ConvertTooltipText: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 10:35:18 +00:00
ragnarok-clanker
92886d28ca Decompile 2 functions in Source/Contents/Items/ItemInfo.cpp, Source/Contents/Items/ItemInfo.h, ...
Batch #1329 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_23633 CSession::ClearItemSelection: logic confirmed by peer review
- fn_17254 UIWindowMgr::NotifyMode: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 10:30:24 +00:00