Commit graph

47 commits

Author SHA1 Message Date
ragnarok-clanker
545678314f Decompile fn_02254 (LightmappedBuffer::Clear)
Batch #1389 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_02254 LightmappedBuffer::Clear: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 12:11:17 +00:00
ragnarok-clanker
713acc513f Decompile fn_02450 (CreateTexture)
Batch #1365 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_02450 CreateTexture: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 11:42:11 +00:00
ragnarok-clanker
83391f8a3a Decompile fn_01853 (CDCBitmap::SetAlpha)
Batch #1307 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_01853 CDCBitmap::SetAlpha: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 11:07:52 +00:00
ragnarok-clanker
f8fb45fb1e Decompile fn_02097 (CRenderer::ScaleDistance)
Batch #1344 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_02097 CRenderer::ScaleDistance: logic confirmed by peer review (annotation added to existing code)

Reviewed-by: ragnarok-clanker
2026-10-28 11:01:55 +00:00
ragnarok-clanker
3b1bd4bb08 Decompile 3 functions in Source/Render/Primitives/RenderPrimitive.cpp, Source/Render/Primitives/RenderPrimitive.h
Batch #1339 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_02255 RenderPrimitive::operator=: logic confirmed by peer review
- fn_02256 RenderCommand::AllocateTriangles: logic confirmed by peer review
- fn_02264 RenderCommand::SetPosition: logic confirmed by peer review

Peer-reviewed-by: tester
Reviewed-by: ragnarok-clanker
2026-10-28 10:55:47 +00:00
ragnarok-clanker
22d7370193 Decompile 4 functions in Source/Contents/Items/ItemInfo.cpp, Source/Contents/Items/ItemInfo.h, ...
Batch #1336 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_02473 CTexture::Touch: logic confirmed by peer review
- fn_06603 ItemInfo::IsApprenticeItem: logic confirmed by peer review
- fn_24179 CSession::IsReducedSkill: logic confirmed by peer review
- fn_23614 CSession::ConvertTooltipText: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 10:35:18 +00:00
ragnarok-clanker
6783952b1d Decompile fn_01866 (CDCSurface::Reset)
Batch #1295 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_01866 CDCSurface::Reset: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 07:14:40 +00:00
ragnarok-clanker
ffddbb948f Decompile 4 functions in Source/Render/Text/TextContext.cpp
Batch #1264 by ragnarok-clanker: 4 byte-identical, 0 confirmed by peer review.

- fn_01979 Sub5504E0: byte-identical
- fn_01980 Sub5504F0: byte-identical
- fn_01981 Sub550500: byte-identical
- fn_01982 Sub550510: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 00:52:57 +00:00
ragnarok-clanker
128b956184 Decompile 2 functions in Source/Render/Renderer.cpp, Source/Render/Renderer.h
Batch #1260 by ragnarok-clanker: 2 byte-identical, 0 confirmed by peer review.

- fn_02098 CRenderer::UiScaleX: byte-identical
- fn_02099 CRenderer::UiScaleY: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 00:04:42 +00:00
ragnarok-clanker
61943206fb Decompile fn_08054 (CSprRes::Load)
Batch #1201 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_08054 CSprRes::Load: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-27 21:08:39 +00:00
ragnarok-clanker
2d4cc46314 Decompile fn_02412 (SpriteAtlas::ClearExpired)
Batch #1182 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_02412 SpriteAtlas::ClearExpired: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 21:07:20 +00:00
ragnarok-clanker
b2b69ae8b2 Decompile 4 functions in Source/Render/DX7/RenderSystemDX7.cpp
Batch #1174 by eAthena: 0 byte-identical, 4 confirmed by peer review.

- fn_02307 CRenderSystemDX7::CRenderSystemDX7: logic confirmed by peer review
- fn_02315 CRenderSystemDX7::`scalar deleting destructor': logic confirmed by peer review
- fn_02328 CRenderSystemDX7::BackBufferTexture: logic confirmed by peer review
- fn_02330 CRenderSystemDX7::BackBufferSurface: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 21:06:46 +00:00
ragnarok-clanker
54a6422ade Decompile 2 functions in Source/Render/DX7/RenderSystemDX7.cpp
Batch #1175 by eAthena: 2 byte-identical, 0 confirmed by peer review.

- fn_02329 CRenderSystemDX7::Height: byte-identical
- fn_02335 CRenderSystemDX7::IsWindowed: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-27 20:56:08 +00:00
ragnarok-clanker
9fef90851e Decompile 14 functions in Source/Contents/UserData/NormalItemSlots.cpp, Source/Contents/UserData/NormalItemSlots.h, ...
Batch #1162 by eAthena: 14 byte-identical, 0 confirmed by peer review.

- fn_13679 CashEmotionListWndInfo::Reset: byte-identical
- fn_13680 ChatRoomWndInfo::Reset: byte-identical
- fn_13681 ChooseWndInfo::Reset: byte-identical
- fn_13682 ClanWndInfo::Reset: byte-identical
- fn_13683 CombinedCardItemCollectionWndInfo::Reset: byte-identical
- fn_13684 UnusedWndInfoA::Reset: byte-identical
- fn_13685 EmotionWndInfo::Reset: byte-identical
- fn_13686 EquipWndInfo::Reset: byte-identical
- fn_13687 ExchangeAcceptWndInfo::Reset: byte-identical
- fn_13688 FriendOptionWndInfo::Reset: byte-identical
- fn_13689 GuildHelperWndInfo::Reset: byte-identical
- fn_13691 HomunInfoWndInfo::Reset: byte-identical
- fn_13692 ItemCollectionWndInfo::Reset: byte-identical
- fn_13694 ItemStoreFindWndInfo::Reset: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-27 20:45:34 +00:00
ragnarok-clanker
ea6e4e5492 Decompile 2 functions in Source/Render/Text/TextContext.cpp, Source/Render/Text/TextContext.h
Batch #1115 by Kisuka: 0 byte-identical, 2 confirmed by peer review.

- fn_01967 TextContext::SetBackgroundColor: logic confirmed by peer review
- fn_01968 TextContext::SetBackgroundMode: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 19:42:10 +00:00
ragnarok-clanker
cc5f17c4c4 Decompile 6 functions in Source/Render/DeviceContext/DCSurface.cpp
Batch #1112 by Kisuka: 0 byte-identical, 6 confirmed by peer review.

- fn_02275 RenderSystemHolder::CreateSurface: logic confirmed by peer review
- fn_02276 RenderSystemHolder::CreateTexture: logic confirmed by peer review
- fn_02277 RenderSystemHolder::CreateSurfaceOrTexture: logic confirmed by peer review
- fn_02279 RenderSystemHolder::DestroySurface: logic confirmed by peer review
- fn_02286 DefaultResolution: logic confirmed by peer review
- fn_02296 RenderSystemHolder::Present: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 19:41:25 +00:00
ragnarok-clanker
b7989fffcd Decompile fn_01935 (FontCache::FontCache)
Batch #1092 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_01935 FontCache::FontCache: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 18:09:12 +00:00
ragnarok-clanker
cbbf28e4de Maintenance: Add mandatory field offset markers /* XXXX */ and assertions to Render headers (DX7, DX9, Primitives, Text, Textures)
Batch #1060 by ragnarok-clanker: no function's compiled code changes; checked with 188 compiled unit(s), including every includer of Source/Render/DX7/DeviceOwnerDX7.h, Source/Render/DX7/DirectDrawEnumeration.h, Source/Render/DX7/RenderSystemDX7.h, Source/Render/DX7/RendererFogDX7.h, Source/Render/DX7/SurfaceDX7.h, Source/Render/DX9/DeviceOwnerDX9.h, Source/Render/DX9/DeviceStateDX9.h, Source/Render/DX9/RendererFogDX9.h, Source/Render/DeviceContext/DCSurface.h, Source/Render/DisplayMode.h, Source/Render/Primitives/LightmappedPrimitive.h, Source/Render/Primitives/RenderCommandPool.h, Source/Render/Primitives/RenderPrimitive.h, Source/Render/Primitives/RenderPrimitivePool.h, Source/Render/Primitives/RenderQueues.h, Source/Render/Primitives/RenderVertexPool.h, Source/Render/Projection/RendererViewport.h, Source/Render/RenderAdapter.h, Source/Render/Renderer.h, Source/Render/RendererBackBuffer.h, Source/Render/Text/TextContext.h, Source/Render/Textures/BitmapTextureCache.h, Source/Render/Textures/SpriteAtlas.h, Source/Render/Textures/Surface.h.
2026-10-27 13:48:11 +00:00
ragnarok-clanker
c60cbe211b Decompile 2 functions in Source/Client/ModeFadeOut.cpp, Source/Client/ModeFadeOut.h, ...
Batch #1037 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_17847 FadeOutMode: logic confirmed by peer review
- fn_17148 DrawBitmapResource: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Client/ModeFadeOut.cpp, Source/Render/BitmapDrawing.cpp
2026-10-27 10:19:58 +00:00
ragnarok-clanker
f3ceb09e9d Merge commit '6c40a36577' 2026-10-27 10:06:35 +00:00
ragnarok-clanker
2035aa96de Decompile 2 functions in Source/Render/AlphaRectangle.cpp, Source/Client/ModeFade.cpp, ...
Batch #1027 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_01952 DrawAlphaRectangle: logic confirmed by peer review
- fn_17842 ModeFade::Draw: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Render/AlphaRectangle.cpp, Source/Client/ModeFade.cpp
2026-10-27 10:04:54 +00:00
ragnarok-clanker
e331e03f4c 📝 docs(headers): annotated inlined methods 2026-10-27 10:43:00 +01:00
ragnarok-clanker
ff15df90ad 📝 docs(annotations): marked inlined functions across modules 2026-10-27 10:42:13 +01:00
ragnarok-clanker
3dbd276311 📚 docs(inlining): marked inlined functions across modules 2026-10-27 10:21:57 +01:00
ragnarok-clanker
add868efe7 ♻️ refactor(source): removed unused includes and add INLINE comments 2026-10-27 10:09:10 +01:00
ragnarok-clanker
fba5ab8527 Merge branch 'main' of https://clank.rodecomp.online/git/clank/rodecomp 2026-10-27 10:02:57 +01:00
ragnarok-clanker
779dd40d2e 🛠️ refactor(source): annotated inlined functions and removed unused include 2026-10-27 10:01:19 +01:00
ragnarok-clanker
38defb749a 🛠️ fix(FontCache): attached STATIC 0x01311ED0 to the fallback font table 2026-10-27 10:00:45 +01:00
ragnarok-clanker
c5aea5fa76 📝 docs(models,render): added inlined comments to functions 2026-10-27 09:57:08 +01:00
ragnarok-clanker
2282078421 Decompile fn_01787 (DeviceOwnerDX7::PackColor)
Batch #970 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_01787 DeviceOwnerDX7::PackColor: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 00:21:32 +00:00
ragnarok-clanker
35b31fdf7b Decompile 6 functions in Source/Archive/PakRegistry.h, Source/Render/DeviceContext/DCSurface.h, ...
Batch #937 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_17771 LanguageCharset: logic confirmed by peer review (annotation added to existing code)
- fn_17773 LanguageCodePage: logic confirmed by peer review (already on main)
- fn_02102 GetRenderSystemHolder: logic confirmed by peer review
- fn_18112 PakRegistry::Read: logic confirmed by peer review (already on main)
- fn_18114 PakRegistry::ReadArchive: logic confirmed by peer review (already on main)
- fn_04728 CMouse::Center: logic confirmed by peer review (already on main)

Reviewed-by: ragnarok-clanker
2026-10-26 23:29:56 +00:00
ragnarok-clanker
bf6a44c117 Group Utility units into subsystem folders and require OFFSET provenance
Move Lexicon*, Text (TextTokens, TextEscapes, Base64), Math/RadialGrid, Hash (MD5, XxHash32) and Cipher (Rijndael, XorBytes) into Source/Utility subfolders; update includes, guards, compile.json and CMakeLists.txt. Backfill // OFFSET: above every standalone // FUNCTION: block (89 IDs, addresses from the symbol database) and make it mandatory in CODING_RULES.md and AGENTS.md. Remove the MatchLexicon cast chain.
2026-10-26 23:41:07 +01:00
ragnarok-clanker
caea0f2937 Decompile fn_01842 (ApplyPixelFilter)
Batch #911 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_01842 ApplyPixelFilter: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-26 22:07:53 +00:00
ragnarok-clanker
b3b7fd0281 Decompile 2 functions in Source/Render/ViewportProjection.cpp, Source/Render/Renderer.h
Batch #836 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_02104 CRenderer::ProjectViewport: logic confirmed by peer review
- fn_02105 CRenderer::ProjectViewportCentered: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Render/ViewportProjection.cpp
2026-10-26 21:50:07 +00:00
ragnarok-clanker
e2351a9e3a Decompile fn_01845 (CDCBitmap::Create)
Batch #833 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_01845 CDCBitmap::Create: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-26 21:49:25 +00:00
ragnarok-clanker
f575258340 Maintenance: Define every global once in its owner unit; session members replace member globals
Batch #906 by ragnarok-clanker: no function's compiled code changes; checked with 9 compiled unit(s), including every includer of Source/Client/Session.h, Source/Client/Registry.h, Source/Client/Application/LaunchInfo.h, Source/Client/Application/Launcher.h, Source/Client/Mode/ActiveGameMode.h, Source/Render/DeviceSelection.h.
Adds to the build: Source/Client/Session.cpp, Source/Client/Registry.cpp, Source/Client/Application/LaunchInfo.cpp, Source/Render/DeviceSelection.cpp
2026-10-26 18:34:25 +00:00
ragnarok-clanker
1dccbfbae5 Maintenance: Annotate globals on their definitions only; drop annotations from header externs
Batch #904 by ragnarok-clanker: no function's compiled code changes; checked with 3 compiled unit(s), including every includer of Source/Contents/MessageTable.h, Source/Contents/Async/AsyncWorkMgr.h, Source/Contents/Emblems/EmblemDataMgr.h, Source/Contents/Hotkeys/UserHotkeyMgr.h, Source/Contents/Messenger/WhisperBlockMgr.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/UserData/AccountLinkedUserDataMgr.h, Source/Contents/UserData/CharacterLinkedUserDataMgr.h, Source/Network/TextEncoding.h, Source/Network/Http/CURLMgr.h, Source/Render/Textures/Texture.h, Source/UI/Layout/SnapMgr.h, Source/UI/Party/UIRequestJoinPartyMgr.h, Source/UI/Window/FrameFocus.h, Source/UI/Window/UIWindow.h, Source/Utility/Async/NMessageMgr.h.
2026-10-26 18:25:54 +00:00
ragnarok-clanker
b2126aca53 Decompile fn_01907 (DeviceOwnerDX9Noop)
Batch #897 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_01907 DeviceOwnerDX9Noop: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-26 15:11:59 +00:00
ragnarok-clanker
e168b4e4a6 Restore translation-unit ownership and publish verified source corrections
Owner-authorized source migration: 31 helper-only translation units were merged into their callers or existing inline headers; both build manifests updated. Includes the preserved source payload, Lua configuration matching wowdecomp, and exact malloca expansion without diagnostic pragmas.

449 native units compiled locally and 449 staged units compiled by the pinned server toolchain. No previously byte-matched function regressed. Compiler mapping diagnostics remain recorded as needs_cleanup, not accepted or peer-confirmed. Existing independent review records are preserved. README.md is intentionally unchanged.
2026-10-25 15:42:21 +00:00
ragnarok-clanker
a47d20f8be Reconstruct readable C++ and organize cohesive source subsystems
Administrative source import: native x86 compilation passed for 423 authored units. Source placement and submission states are migrated separately; this commit does not imply peer acceptance.

Previous head: 35d2a8cb36
Payload SHA256: 592f016d2730c5593bb653aa054c1e5f76a6df72c8f5a09e66f74876e2e33dee
2026-10-25 07:42:41 +00:00
ragnarok-clanker
35d2a8cb36 Decompile fn_01906 (DeviceOwnerDX9::DeviceOwnerDX9)
Batch #155 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_01906 DeviceOwnerDX9::DeviceOwnerDX9: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-24 20:59:54 +00:00
ragnarok-clanker
d60b669197 Decompile fn_02472 (CTexture::Release)
Batch #140 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_02472 CTexture::Release: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-24 19:25:08 +00:00
ragnarok-clanker
bb8ac68b8e Decompile 11 functions in Source/Render/DCSurface.cpp, Source/Render/DCSurface.h
Batch #136 by ragnarok-clanker: 11 byte-identical, 0 confirmed by peer review.

- fn_02274 RenderSystemHolder::CreateRenderer: byte-identical
- fn_02278 RenderSystemHolder::Close: byte-identical
- fn_02280 RenderSystemHolder::UpdateOption: byte-identical
- fn_02281 RenderSystemHolder::RestoreDisplayMode: byte-identical
- fn_02282 RenderSystemHolder::PrepareErrorDialog: byte-identical
- fn_02285 RenderSystemHolder::Backend: byte-identical
- fn_02287 RenderSystemHolder::BackBufferTexture: byte-identical
- fn_02288 RenderSystemHolder::Height: byte-identical
- fn_02292 RenderSystemHolder::Width: byte-identical
- fn_02294 RenderSystemHolder::IsWindowed: byte-identical
- fn_02295 RenderSystemHolder::TestDevice: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-24 18:58:32 +00:00
ragnarok-clanker
b31bc5ec1f Decompile 11 functions in Source/Render/SurfaceDX7.cpp, Source/Render/DeviceOwnerDX7.h
Batch #118 by ragnarok-clanker: 11 byte-identical, 0 confirmed by peer review.

- fn_01788 DeviceOwnerDX7::BlueMask: byte-identical
- fn_01789 DeviceOwnerDX7::BlueExpansion: byte-identical
- fn_01790 DeviceOwnerDX7::BlueShift: byte-identical
- fn_01792 DeviceOwnerDX7::DirectDraw: byte-identical
- fn_01793 DeviceOwnerDX7::GreenMask: byte-identical
- fn_01794 DeviceOwnerDX7::GreenExpansion: byte-identical
- fn_01795 DeviceOwnerDX7::GreenShift: byte-identical
- fn_01797 DeviceOwnerDX7::RedMask: byte-identical
- fn_01798 DeviceOwnerDX7::RedExpansion: byte-identical
- fn_01799 DeviceOwnerDX7::RedShift: byte-identical
- fn_01800 DeviceOwnerDX7::RenderTarget: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-24 17:53:08 +00:00
ragnarok-clanker
56a8b6f167 Decompile fn_02243 (CRendererDX9::UnlockBackBuffer)
Batch #86 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_02243 CRendererDX9::UnlockBackBuffer: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-24 14:02:37 +00:00
ragnarok-clanker
57a754c75b Decompile fn_02251 (RenderVertex::Reset)
Batch #4 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_02251 RenderVertex::Reset: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-24 01:38:32 +00:00
ragnarok-clanker
d456e8f64a Initial rodecomp source snapshot 2026-10-24 00:35:19 +00:00